Skip to content

feat: support new monorepo setup #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2023
Merged

feat: support new monorepo setup #2260

merged 3 commits into from
Aug 14, 2023

Conversation

eduardoboucas
Copy link
Member

Description

Changes the function path resolution logic to account for the new packagePath property, such that functions are placed in the .netlify/functions-internal directory inside the package path and not at the repository root.

Relevant links (GitHub issues, etc.) or a picture of cute animal

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for monumental-licorice-cb7c10 failed.

Name Link
🔨 Latest commit 879d029
🔍 Latest deploy log https://app.netlify.com/sites/monumental-licorice-cb7c10/deploys/64da1ddcadee5b00084fcd9c

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit d5eb1a4
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/64da2ff4b167840008a4a42f
😎 Deploy Preview https://deploy-preview-2260--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit d5eb1a4
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/64da2ff43c560e0008f3af68
😎 Deploy Preview https://deploy-preview-2260--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit d5eb1a4
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/64da2ff46dd56a00081e1b26
😎 Deploy Preview https://deploy-preview-2260--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Aug 11, 2023
@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit 073a876
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/64d66a4a4f0b9e0008009a22
😎 Deploy Preview https://deploy-preview-2260--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit 073a876
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/64d66a4ae01aa300087cd45e
😎 Deploy Preview https://deploy-preview-2260--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit 073a876
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/64d66a4af4b3170008818338
😎 Deploy Preview https://deploy-preview-2260--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit 073a876
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/64d66a4a9c2fa20008cca1a5
😎 Deploy Preview https://deploy-preview-2260--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit 073a876
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/64d66a4aa77a670008034823
😎 Deploy Preview https://deploy-preview-2260--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit 073a876
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/64d66a4ab56e3f000811eb86
😎 Deploy Preview https://deploy-preview-2260--next-plugin-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit d5eb1a4
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/64da2ff42866040008f255a2
😎 Deploy Preview https://deploy-preview-2260--next-plugin-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit d5eb1a4
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/64da2ff46a201f0007b9ed5b
😎 Deploy Preview https://deploy-preview-2260--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit d5eb1a4
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/64da2ff4cba11d0008e1b10e
😎 Deploy Preview https://deploy-preview-2260--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit d5eb1a4
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/64da2ff4141e520009bbbf5f
😎 Deploy Preview https://deploy-preview-2260--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit d5eb1a4
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/64da2ff430bd1800072710f3
😎 Deploy Preview https://deploy-preview-2260--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/64da319f7b37a0420501a757
😎 Deploy Preview https://deploy-preview-2260--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lukasholzer lukasholzer force-pushed the feat/monorepo-changes branch from 33a60ae to 6a9b906 Compare August 14, 2023 11:53
@lukasholzer lukasholzer requested review from pieh and minivan August 14, 2023 11:53
@lukasholzer lukasholzer marked this pull request as ready for review August 14, 2023 11:53
@lukasholzer lukasholzer requested a review from a team as a code owner August 14, 2023 11:53
@lukasholzer lukasholzer force-pushed the feat/monorepo-changes branch from 3b40f0f to f368182 Compare August 14, 2023 12:08
@pieh pieh self-assigned this Aug 14, 2023
@pieh pieh added the automerge label Aug 14, 2023
@kodiakhq kodiakhq bot merged commit 7185d62 into main Aug 14, 2023
@kodiakhq kodiakhq bot deleted the feat/monorepo-changes branch August 14, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants