-
Notifications
You must be signed in to change notification settings - Fork 86
chore: move to paths relative to monorepo root for new monorepo support #2259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move to paths relative to monorepo root for new monorepo support #2259
Conversation
❌ Deploy Preview for next-plugin-edge-middleware failed.
|
❌ Deploy Preview for netlify-plugin-nextjs-export-demo failed.
|
❌ Deploy Preview for monumental-licorice-cb7c10 failed.
|
❌ Deploy Preview for netlify-plugin-nextjs-demo failed.
|
❌ Deploy Preview for next-i18next-demo failed.
|
❌ Deploy Preview for netlify-plugin-nextjs-static-root-demo failed.
|
❌ Deploy Preview for nextjs-plugin-custom-routes-demo failed.
|
❌ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo failed.
|
I need to update the base paths in the Netlify UI. For the time being, everything should fail. |
❌ Deploy Preview for netlify-plugin-nextjs-next-auth-demo failed.
|
❌ Deploy Preview for next-plugin-canary failed.
|
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to adapt the ignore command as well:
- ignore = "if [ $CACHED_COMMIT_REF == $COMMIT_REF ]; then (exit 1); else git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF ../..; fi;"
+ ignore = "if [ $CACHED_COMMIT_REF == $COMMIT_REF ]; then (exit 1); else git diff --quiet $CACHED_COMMIT_REF $COMMIT_REF; fi;"
as it's run from the repo root there is no need to cd outside of the repo with ../..
Description
Brings the project in line with the improved monorepo support. I'm off next week and there are some incoming changes to the CLI for this. As well, we need to modify the Next.js runtime to take into account the new
PACKAGE_PATH
constant so that we can build the functions in the package folder and not the monorepo root, (see the work @eduardoboucas has done in #2260) e.g.Aside from the configuration changes, the demo sites need to be reconfigured in the Netlify UI so that the base path is
/
instead of e.g.demos/default
.There are also E2E tests that run the Next.js E2E test suite that use the Netlify CLI, but the sites generated are not monorepo packages being created via the CLI, so those should not require and changes.
Note that all the demo sites in this PR will fail to build until the base paths are updated in the Netlify UI.
@pieh might take this over next week, but if not, I'll resume this work when I'm back.
Tests
All the demo sites should deploy as usual with the updated configurations and all checks are green.
Relevant links (GitHub issues, etc.) or a picture of cute animal
packagePath
to compute internal functions directories netlify/cli#5944