Skip to content

fix: failing test for background functions #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented May 17, 2023

Description

Closes #2122

Documentation

Tests

You can test this change yourself like so:

  1. TODO

Relevant links (GitHub issues, etc.) or a picture of cute animal

@Skn0tt Skn0tt requested a review from a team as a code owner May 17, 2023 09:53
@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for netlify-plugin-nextjs-demo canceled.

Name Link
🔨 Latest commit e925fff
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/64c27291cc6d3d0008e5d9b0

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo canceled.

Name Link
🔨 Latest commit e925fff
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/64c2729191321e000827b27d

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for next-i18next-demo canceled.

Name Link
🔨 Latest commit e925fff
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/64c272911c04400008218be0

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for netlify-plugin-nextjs-static-root-demo canceled.

Name Link
🔨 Latest commit e925fff
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/64c27291ddebd30008343996

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for next-plugin-canary canceled.

Name Link
🔨 Latest commit e925fff
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/64c27291cc6d3d0008e5d9aa

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for netlify-plugin-nextjs-export-demo canceled.

Name Link
🔨 Latest commit e925fff
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/64c27291c624440008bc09f2

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit e925fff
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/64c27291fba3740008f69da9
😎 Deploy Preview https://deploy-preview-2123--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for netlify-plugin-nextjs-next-auth-demo canceled.

Name Link
🔨 Latest commit e925fff
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/64c27291fdd9230008237cff

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for nextjs-plugin-custom-routes-demo canceled.

Name Link
🔨 Latest commit e925fff
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/64c27291ddebd3000834399c

@github-actions github-actions bot added the type: bug code to address defects in shipped code label May 17, 2023
@@ -1,4 +1,6 @@
export default (req, res) => {
export default async (req, res) => {
await fetch(`https://webhook.site/${req.body.token}`)

Check failure

Code scanning / CodeQL

Server-side request forgery

The [URL](1) of this request depends on a [user-provided value](2).
@Skn0tt Skn0tt marked this pull request as draft May 17, 2023 10:15
@nickytonline
Copy link

@Skn0tt, do you want us to take this over?

@Skn0tt
Copy link
Contributor Author

Skn0tt commented Jul 27, 2023

that'd be lovely!

@Skn0tt Skn0tt closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E2E test for background functions
2 participants