Skip to content

Add E2E test for background functions #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Skn0tt opened this issue May 17, 2023 · 2 comments
Closed

Add E2E test for background functions #2122

Skn0tt opened this issue May 17, 2023 · 2 comments
Labels
reliability code to address reliability issues v4 Issues related to the v4 Next.js runtime

Comments

@Skn0tt
Copy link
Contributor

Skn0tt commented May 17, 2023

In #2058 we introduced a regression around experimental-background functions. It was fixed in #2121, and could've been caught by an E2E test.

We should build an E2E test that asserts on background functions running to completion, maybe using a tool like https://webhook.site/.
@Skn0tt Skn0tt mentioned this issue May 17, 2023
Merged
@Skn0tt Skn0tt self-assigned this May 17, 2023
@Skn0tt Skn0tt mentioned this issue May 17, 2023
Closed
@MarcL MarcL added the reliability code to address reliability issues label Jul 6, 2023
@nickytonline
Copy link

We'll be taking this over from @Skn0tt.

@MarcL MarcL added Ecosystem: Frameworks v4 Issues related to the v4 Next.js runtime and removed Ecosystem: Frameworks labels Mar 13, 2024
@MarcL
Copy link
Contributor

MarcL commented Apr 19, 2024

Closing this as we won't be doing this in the v4 runtime now we have solid testing in the v5 runtime.

@MarcL MarcL closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reliability code to address reliability issues v4 Issues related to the v4 Next.js runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: failing test for background functions opennextjs/opennextjs-netlify
3 participants
@nickytonline @MarcL @Skn0tt