Skip to content

fix: routes with null data routes can be filtered now #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 4, 2023
Merged

fix: routes with null data routes can be filtered now #2018

merged 8 commits into from
Apr 4, 2023

Conversation

nickytonline
Copy link

@nickytonline nickytonline commented Mar 27, 2023 •
edited
Loading

Summary

Types in the project were not up to day and

Closes #1940

Test plan

  1. Ensure the deploy previews are green.
  2. There are tests that cover this fix.

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

@netlify
Copy link

netlify bot commented Mar 27, 2023 •
edited
Loading

✅ Deploy Preview for next-i18next-demo canceled.

Name Link
🔨 Latest commit 5ca2497
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/642c458ced3f0d0008796f3a

@netlify
Copy link

netlify bot commented Mar 27, 2023 •
edited
Loading

✅ Deploy Preview for next-plugin-canary canceled.

Name Link
🔨 Latest commit 5ca2497
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/642c458cf08ff80008570135

@netlify
Copy link

netlify bot commented Mar 27, 2023 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-export-demo canceled.

Name Link
🔨 Latest commit 5ca2497
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/642c458c796e81000836aad5

@netlify
Copy link

netlify bot commented Mar 27, 2023 •
edited
Loading

✅ Deploy Preview for next-plugin-edge-middleware canceled.

Name Link
🔨 Latest commit 5ca2497
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/642c458c673f0e000888d9e2

@netlify
Copy link

netlify bot commented Mar 27, 2023 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo canceled.

Name Link
🔨 Latest commit 5ca2497
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/642c458c65bc410008abd1b3

@netlify
Copy link

netlify bot commented Mar 27, 2023 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-demo canceled.

Name Link
🔨 Latest commit 5ca2497
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/642c458c8b22520008cf5196

@netlify
Copy link

netlify bot commented Mar 27, 2023 •
edited
Loading

✅ Deploy Preview for nextjs-plugin-custom-routes-demo canceled.

Name Link
🔨 Latest commit 5ca2497
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/642c458c6b2f6e000874c5a3

@netlify
Copy link

netlify bot commented Mar 27, 2023 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo canceled.

Name Link
🔨 Latest commit 5ca2497
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/642c458c38ce6c000879940a

@netlify
Copy link

netlify bot commented Mar 27, 2023 •
edited
Loading

✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo canceled.

Name Link
🔨 Latest commit 5ca2497
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/642c458cd7b3ee0007afc896

@nickytonline nickytonline self-assigned this Mar 27, 2023
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Mar 27, 2023
@nickytonline nickytonline marked this pull request as ready for review March 27, 2023 21:52
@nickytonline nickytonline requested a review from a team March 27, 2023 21:52
@nickytonline nickytonline marked this pull request as draft March 27, 2023 22:12
@nickytonline nickytonline force-pushed the nickytonline/fix-for-1940-app-dir-null-data-route branch from d4e6c20 to acbc271 Compare April 3, 2023 19:35
@nickytonline nickytonline marked this pull request as ready for review April 3, 2023 19:37
@nickytonline nickytonline mentioned this pull request Apr 3, 2023
Closed
@nickytonline nickytonline force-pushed the nickytonline/fix-for-1940-app-dir-null-data-route branch from a71bcea to 70c2620 Compare April 4, 2023 12:09
orinokai
orinokai approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@orinokai orinokai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kodiakhq kodiakhq bot merged commit 7c1673b into main Apr 4, 2023
@kodiakhq kodiakhq bot deleted the nickytonline/fix-for-1940-app-dir-null-data-route branch April 4, 2023 15:47
@token-generator-app token-generator-app bot mentioned this pull request Apr 4, 2023
Merged
@nickytonline nickytonline mentioned this pull request Apr 13, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orinokai orinokai orinokai approved these changes

Assignees

@nickytonline nickytonline

Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: appDir applications can have dataRoute: null
2 participants
@nickytonline @orinokai