Bug: `appDir` applications can have `dataRoute: null` #1940

Skn0tt · 2023-02-24T11:01:38Z

When you run next build on https://github.com/redmonkez12/interactive-rating-component/tree/079f65a9b1d84efe2c1032dc01c022b46a7c0fb5, then prerender-manifest.json will contain

"/api/hello": {
    "initialHeaders": { "content-type": "text/plain;charset=UTF-8" },
    "initialRevalidateSeconds": false,
    "srcRoute": "/api/hello",
    "dataRoute": null
  }

Our runtime currently can't handle that, and will throw an error here, because dataRoute is null:

https://github.com/netlify/next-runtime/blob/72ab895be865402fa0d92431f293129c70ae6c8b/packages/runtime/src/templates/edge-shared/rsc-data.ts#L38

To fix that, we should update the Next.js version that this repo is pulling TS types from, and fix all places where the types now fail.

The text was updated successfully, but these errors were encountered:

MarcL · 2023-02-24T11:42:02Z

Feels like this is a high priority so I've added it to the current iteration as an "up next".

voyagebagage · 2023-03-16T08:52:43Z

When you run next build on https://github.com/redmonkez12/interactive-rating-component/tree/079f65a9b1d84efe2c1032dc01c022b46a7c0fb5, then prerender-manifest.json will contain
"/api/hello": {
    "initialHeaders": { "content-type": "text/plain;charset=UTF-8" },
    "initialRevalidateSeconds": false,
    "srcRoute": "/api/hello",
    "dataRoute": null
  }
Our runtime currently can't handle that, and will throw an error here, because dataRoute is null:

https://github.com/netlify/next-runtime/blob/72ab895be865402fa0d92431f293129c70ae6c8b/packages/runtime/src/templates/edge-shared/rsc-data.ts#L38

To fix that, we should update the Next.js version that this repo is pulling TS types from, and fix all places where the types now fail.

so no fix yet right?
I have same problem I have tried to deploy my project at the start without almost any code, just setting tailwind and chakra ui on Next13 last version but the deploy is failing the same way

REPO

I don't know if any relation, but whenever I put an UI to Next13 I have an hydratation error :

hydration-error-info.js?32aa:27 Warning: Extra attributes from the server: cz-shortcut-listen
at body
at html
at RootLayout (webpack-internal:///(app-client)/./app/layout.tsx:37:11)

hrishikesh-k · 2023-03-26T12:03:13Z

Some threads where users are seeing this as an issue:

https://netlify.zendesk.com/agent/tickets/137136
https://netlify.zendesk.com/agent/tickets/141826
https://netlify.zendesk.com/agent/tickets/137386
https://answers.netlify.com/t/87475
https://answers.netlify.com/t/88394
https://answers.netlify.com/t/86328

nickytonline · 2023-03-27T20:12:07Z

I upgraded to the latest version of Next.js 13.2.4 and these are the types now.

We can definitely upgrade Next.js in the project to get the new types, but the it can be fixed even without that update.

export const getRscDataRouter = ({ routes: staticRoutes, dynamicRoutes }: PrerenderManifest): EdgeFunction => {
  const staticRouteSet = new Set(
    Object.entries(staticRoutes)
-      .filter(([, { dataRoute }]) => dataRoute.endsWith('.rsc'))
+      .filter(([, { dataRoute }]) => dataRoute?.endsWith('.rsc')) 
      .map(([route]) => route),
  )
...

From what I can tell this isn't picked up in the codebase (even with the Next.js update) because it's a file that is copied. See

https://github.com/netlify/next-runtime/blob/4185df0597c8db45b6f67631820f10cf6140af07/packages/runtime/src/helpers/edge.ts#L293-L295

I'm going to go ahead and put up a fix for this, and I'll create a separate issue for updating the Next.js version in the repo.

narbota · 2023-03-28T22:09:33Z

Hello, I'm getting the same error as well when deploying Nextjs 13 site https://app.netlify.com/sites/next-13-trail/deploys/6423617b0dc578000711a6fe
Internal error during Edge functions budling" 5:53:04 PM: 5. Edge Functions bundling
5:53:04 PM: ────────────────────────────────────────────────────────────────
5:53:04 PM:
5:53:04 PM: Packaging Edge Functions from .netlify/edge-functions directory:
5:53:04 PM: - rsc-data
5:53:05 PM: TypeError: Cannot read properties of null (reading 'endsWith')
5:53:05 PM: at file:///opt/build/repo/.netlify/edge-functions/edge-shared/rsc-data.ts:38:48
5:53:05 PM: at Array.filter ()
5:53:05 PM: at getRscDataRouter (file:///opt/build/repo/.netlify/edge-functions/edge-shared/rsc-data.ts:38:8)
5:53:05 PM: at file:///opt/build/repo/.netlify/edge-functions/rsc-data/rsc-data.ts:4:17
5:53:05 PM: Could not load edge function at '/opt/build/repo/.netlify/edge-functions/rsc-data/rsc-data.ts'
5:53:05 PM:
5:53:05 PM: Internal error during "Edge Functions bundling"
5:53:05 PM: ────────────────────────────────────────────────────────────────
5:53:05 PM:
5:53:05 PM: Error message
5:53:05 PM: TypeError: Expected a string

nickytonline · 2023-03-29T12:52:50Z

As mentioned in Slack @narbota, we're currently rolling out v. 4.33.0. If they're not auto-installing, they can upgrade to the latest version of the runtime.

Fox32 · 2023-03-30T07:26:43Z

Upgraded to 4.33.0 today, still hitting the same error:

Packaging Edge Functions from .netlify\edge-functions directory:
 - rsc-data
Could not load edge function at 'C:\Users\Oliver\dev\blog\.netlify\edge-functions\rsc-data\rsc-data.ts'
TypeError: Cannot read properties of null (reading 'endsWith')
    at file:///C:/Users/Oliver/dev/blog/.netlify/edge-functions/edge-shared/rsc-data.ts:38:48
    at Array.filter (<anonymous>)
    at getRscDataRouter (file:///C:/Users/Oliver/dev/blog/.netlify/edge-functions/edge-shared/rsc-data.ts:38:8)
    at file:///C:/Users/Oliver/dev/blog/.netlify/edge-functions/rsc-data/rsc-data.ts:4:17

  Internal error during "Edge Functions bundling"
────────────────────────────────────────────────────────────────

  Error message
  TypeError: Expected a string

  Error location
  During Edge Functions bundling
      at module.exports (C:\Users\Oliver\dev\blog\node_modules\glob-to-regexp\index.js:3:11)
      at pathToRegularExpression (file:///C:/Users/Oliver/dev/blog/node_modules/@netlify/edge-bundler/dist/node/manifest.js:67:31)
      at getRegularExpression (file:///C:/Users/Oliver/dev/blog/node_modules/@netlify/edge-bundler/dist/node/manifest.js:78:12)
      at file:///C:/Users/Oliver/dev/blog/node_modules/@netlify/edge-bundler/dist/node/manifest.js:32:25
      at Array.forEach (<anonymous>)
      at generateManifest (file:///C:/Users/Oliver/dev/blog/node_modules/@netlify/edge-bundler/dist/node/manifest.js:27:18)
      at writeManifest (file:///C:/Users/Oliver/dev/blog/node_modules/@netlify/edge-bundler/dist/node/manifest.js:89:22)
      at bundle (file:///C:/Users/Oliver/dev/blog/node_modules/@netlify/edge-bundler/dist/node/bundler.js:73:28)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async coreStep (file:///C:/Users/Oliver/dev/blog/node_modules/@netlify/build/lib/plugins_core/edge_functions/index.js:35:30)

nickytonline · 2023-04-03T19:34:12Z

@Fox32, apologies, but I mispoke. This fix didn't roll out in v. 4.33.0. I'm adding it to the next release.

ghost · 2023-04-03T23:42:59Z

Hi there, I've been trying unsuccessfully to deploy Next (v13.2.4) with experimental appDir: true BUT with no edge functions at all. It's way impossible having this up and running, nevertheless my setup works fine locally. Also, a different Github project/repo using a previous version of next (13.1.6) worked like a charm when deployed in Netlify, but with the latest one, after trying and trying different workarounds suggested by community users, I keep getting this:

I got nothing fancy, just a fresh nextjs using --typescript... and appDir=true. My dependencies (package.json):

"dependencies": {
"@netlify/plugin-nextjs": "^4.33.0",
"@types/node": "18.15.11",
"@types/react": "18.0.33",
"@types/react-dom": "18.0.11",
"next": "13.2.4",
"react": "18.2.0",
"react-dom": "18.2.0",
"typescript": "5.0.3"
},
"devDependencies": {
"@typescript-eslint/eslint-plugin": "^5.57.1",
"@typescript-eslint/parser": "^5.57.1",
"eslint": "^8.37.0"
}

My next.config.js:

/** @type {import('next').NextConfig} */
const nextConfig = {
reactStrictMode: true,
experimental: {
appDir: true,
},
}
module.exports = nextConfig

...it's really frustrating not seeing any advance on this. Thanks in advance

nickytonline · 2023-04-03T23:56:40Z

@proyectosynergosorg, the fix in #2018 will sort this out. I'm looking to get it merged tomorrow.

Reniactor · 2023-04-05T09:18:55Z

Ohhh so it is a bug on NextJs. Hopefully i'll get to try the fix out tomorrow ;-;

Also, is there any easy way to a workaround or something? :>

kindrift-vt · 2023-04-07T13:33:07Z

@nickytonline Any movement on the fix? I see #2018 was merged but I'm still running into the same issue on my deploys that have internal errors on edge function bundling. I posted on a thread here: https://answers.netlify.com/t/next-app-edge-function-bundling-error/89530

Reniactor · 2023-04-07T13:35:02Z

@kindrift-vt i honestly just used vercel page to deploy the app and it's working perfectly. Didn't have this issue there

nickytonline · 2023-04-07T14:35:17Z

This is fixed and will start rolling out next week @kindrift-vt.

vst · 2023-04-11T03:44:06Z

For the record: with Next.js v13.2, removing /api directory allowed us to deploy the app Netlify. With Next.js v13.3, this approach no longer works.

myko1328 · 2023-04-11T14:13:38Z

hey @nickytonline . I've installed the latest update ("@netlify/plugin-nextjs": "^4.34.0") but encountered another error.

nickytonline · 2023-04-11T20:59:06Z

hey @nickytonline . I've installed the latest update ("@netlify/plugin-nextjs": "^4.34.0") but encountered another error.

@myko1328, this error seems unrelated to the original issue. Mind creating a separate issue for this?

kindrift-vt · 2023-04-11T22:27:30Z

hey @nickytonline . I've installed the latest update ("@netlify/plugin-nextjs": "^4.34.0") but encountered another error.

@myko1328, this error seems unrelated to the original issue. Mind creating a separate issue for this?

Can confirm that @myko1328's error now occurs. this might be related in the sense that the error only surfaced after the fix. Should I make a new issue linking to this?

kindrift-vt · 2023-04-11T22:28:29Z

For the record: with Next.js v13.2, removing /api directory allowed us to deploy the app Netlify. With Next.js v13.3, this approach no longer works.

Did you remove the api directory altogether or remove them from either the /app or /pages dir?

vst · 2023-04-12T04:04:15Z

For the record: with Next.js v13.2, removing /api directory allowed us to deploy the app Netlify. With Next.js v13.3, this approach no longer works.

Did you remove the api directory altogether or remove them from either the /app or /pages dir?

I removed the api directory altogether. This is how I managed to build before v13.3.

kindrift-vt · 2023-04-12T15:25:06Z

For the record: with Next.js v13.2, removing /api directory allowed us to deploy the app Netlify. With Next.js v13.3, this approach no longer works.

Did you remove the api directory altogether or remove them from either the /app or /pages dir?

I removed the api directory altogether. This is how I managed to build before v13.3.

I removed the api directory. Didn't work. But that might be because there can be a new bug?

Maxservais · 2023-04-12T16:57:24Z

Also facing the same issue

jonverne1 · 2023-04-13T14:59:55Z

Same error message as above using the latest versions of Next and the plugin. My Project is created via create-next-app with the appDir. Otherwise I haven't made any other major changes. Runs fine locally.

miketalley · 2023-04-13T18:06:11Z

Hello, I am experiencing this issue as well. I'm also using appDir on a project creates with create-next-app.

  5. Edge Functions bundling                                    
────────────────────────────────────────────────────────────────

Packaging Edge Functions from .netlify/edge-functions directory:
 - rsc-data

Packaging Edge Functions from netlify/edge-functions directory:
 - hello
Local version of types is up-to-date: 643581608391e3000851cc94
No globalVersion or semver not satisfied. globalVersion: undefined, versionRange: ^1.22.0
Using cached Deno CLI from /Users/miketalley/Library/Preferences/netlify/deno-cli/deno
No globalVersion or semver not satisfied. globalVersion: undefined, versionRange: ^1.22.0
No globalVersion or semver not satisfied. globalVersion: undefined, versionRange: ^1.22.0
Using cached Deno CLI from /Users/miketalley/Library/Preferences/netlify/deno-cli/deno
Using cached Deno CLI from /Users/miketalley/Library/Preferences/netlify/deno-cli/deno
No in-source config found for edge function at '/Users/miketalley/Repos/liblab-lotr/netlify/edge-functions/hello.ts'
TypeError: Cannot read properties of null (reading 'endsWith')
    at file:///Users/miketalley/Repos/liblab-lotr/.netlify/edge-functions/edge-shared/rsc-data.ts:38:48
    at Array.filter (<anonymous>)
    at getRscDataRouter (file:///Users/miketalley/Repos/liblab-lotr/.netlify/edge-functions/edge-shared/rsc-data.ts:38:8)
    at file:///Users/miketalley/Repos/liblab-lotr/.netlify/edge-functions/rsc-data/rsc-data.ts:4:17
Could not load edge function at '/Users/miketalley/Repos/liblab-lotr/.netlify/edge-functions/rsc-data/rsc-data.ts'

  Internal error during "Edge Functions bundling"               
────────────────────────────────────────────────────────────────

  Error message
  TypeError: Expected a string

  Error location
  During Edge Functions bundling
      at module.exports (/usr/local/lib/node_modules/netlify-cli/node_modules/@netlify/edge-bundler/node_modules/glob-to-regexp/index.js:3:11)
      at pathToRegularExpression (file:///usr/local/lib/node_modules/netlify-cli/node_modules/@netlify/edge-bundler/dist/node/manifest.js:94:31)
      at getRegularExpression (file:///usr/local/lib/node_modules/netlify-cli/node_modules/@netlify/edge-bundler/dist/node/manifest.js:115:12)
      at file:///usr/local/lib/node_modules/netlify-cli/node_modules/@netlify/edge-bundler/dist/node/manifest.js:60:25
      at Array.forEach (<anonymous>)
      at generateManifest (file:///usr/local/lib/node_modules/netlify-cli/node_modules/@netlify/edge-bundler/dist/node/manifest.js:55:18)
      at writeManifest (file:///usr/local/lib/node_modules/netlify-cli/node_modules/@netlify/edge-bundler/dist/node/manifest.js:136:22)
      at bundle (file:///usr/local/lib/node_modules/netlify-cli/node_modules/@netlify/edge-bundler/dist/node/bundler.js:78:28)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async coreStep (file:///usr/local/lib/node_modules/netlify-cli/node_modules/@netlify/build/lib/plugins_core/edge_functions/index.js:35:30)

nickytonline · 2023-04-13T18:28:27Z

@miketalley an others, the fix for this is in the latest version of the Next.js runtime, 4.34.0. Is that the version of the Next.js runtime you see in your logs @miketalley?

miketalley · 2023-04-13T18:38:13Z

Yes

2:12:10 PM: ❯ Using Next.js Runtime - v4.34.0

jonverne1 · 2023-04-13T18:55:30Z

Here is the output of the build log in Netlify. I have your plugin locked at v4.34.0 in my dev dependencies and [email protected]

MarcL added type: bug code to address defects in shipped code priority: high Ecosystem: Frameworks labels Feb 24, 2023

HassanBahati mentioned this issue Mar 18, 2023

fix site deploy osckampala/evently#9

Closed

nickytonline self-assigned this Mar 27, 2023

nickytonline mentioned this issue Mar 27, 2023

fix: routes with null data routes can be filtered now #2018

Merged

2 tasks

kodiakhq bot closed this as completed in #2018 Apr 4, 2023

nickytonline mentioned this issue Apr 13, 2023

fix: now data routes for dynamic routes filter even when null when creating the RSC data router #2041

Merged

2 tasks

orinokai mentioned this issue Apr 14, 2023

fix: ensure appDir routes with null dataRoutes are not added to edge manifest for rsc-data #2044

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug: `appDir` applications can have `dataRoute: null` #1940

Bug: `appDir` applications can have `dataRoute: null` #1940

Skn0tt commented Feb 24, 2023

MarcL commented Feb 24, 2023

voyagebagage commented Mar 16, 2023 •

edited

Loading

hrishikesh-k commented Mar 26, 2023 •

edited

Loading

nickytonline commented Mar 27, 2023

narbota commented Mar 28, 2023

nickytonline commented Mar 29, 2023

Fox32 commented Mar 30, 2023

nickytonline commented Apr 3, 2023

ghost commented Apr 3, 2023

nickytonline commented Apr 3, 2023

Reniactor commented Apr 5, 2023

kindrift-vt commented Apr 7, 2023

Reniactor commented Apr 7, 2023

nickytonline commented Apr 7, 2023

vst commented Apr 11, 2023

myko1328 commented Apr 11, 2023

nickytonline commented Apr 11, 2023 •

edited

Loading

kindrift-vt commented Apr 11, 2023

kindrift-vt commented Apr 11, 2023

vst commented Apr 12, 2023

kindrift-vt commented Apr 12, 2023

Maxservais commented Apr 12, 2023

jonverne1 commented Apr 13, 2023

miketalley commented Apr 13, 2023

nickytonline commented Apr 13, 2023

miketalley commented Apr 13, 2023

jonverne1 commented Apr 13, 2023

Bug: appDir applications can have dataRoute: null #1940

Bug: appDir applications can have dataRoute: null #1940

Comments

Skn0tt commented Feb 24, 2023

MarcL commented Feb 24, 2023

voyagebagage commented Mar 16, 2023 • edited Loading

hrishikesh-k commented Mar 26, 2023 • edited Loading

nickytonline commented Mar 27, 2023

narbota commented Mar 28, 2023

nickytonline commented Mar 29, 2023

Fox32 commented Mar 30, 2023

nickytonline commented Apr 3, 2023

ghost commented Apr 3, 2023

nickytonline commented Apr 3, 2023

Reniactor commented Apr 5, 2023

kindrift-vt commented Apr 7, 2023

Reniactor commented Apr 7, 2023

nickytonline commented Apr 7, 2023

vst commented Apr 11, 2023

myko1328 commented Apr 11, 2023

nickytonline commented Apr 11, 2023 • edited Loading

kindrift-vt commented Apr 11, 2023

kindrift-vt commented Apr 11, 2023

vst commented Apr 12, 2023

kindrift-vt commented Apr 12, 2023

Maxservais commented Apr 12, 2023

jonverne1 commented Apr 13, 2023

miketalley commented Apr 13, 2023

nickytonline commented Apr 13, 2023

miketalley commented Apr 13, 2023

jonverne1 commented Apr 13, 2023

Bug: `appDir` applications can have `dataRoute: null` #1940

Bug: `appDir` applications can have `dataRoute: null` #1940

voyagebagage commented Mar 16, 2023 •

edited

Loading

hrishikesh-k commented Mar 26, 2023 •

edited

Loading

nickytonline commented Apr 11, 2023 •

edited

Loading