-
Notifications
You must be signed in to change notification settings - Fork 87
fix: updated redirect data urls #1928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
69114ad
fix: updated redirect data urls
taty2010 4320d64
fix: typescript errors and accidental deletion
taty2010 83c1ad5
fix: console logging test
taty2010 a6d69b2
fix: getting the redirect header and normalizing url outisde of orig …
taty2010 f09cf7d
fix: added ref link
taty2010 5efd7da
fix: removing console.log
taty2010 c97c915
Merge branch 'main' into tn/data-redirect
taty2010 bb3cb7c
fix: commenting/reverting changes for testing
taty2010 9917ec9
fix: undo "commenting/reverting changes.."
taty2010 fabf483
Merge branch 'main' into tn/data-redirect
taty2010 c11b39c
Merge branch 'main' into tn/data-redirect
taty2010 d34bf54
Merge branch 'main' into tn/data-redirect
taty2010 e2d051e
Merge branch 'main' into tn/data-redirect
taty2010 f76e1f8
Merge branch 'main' into tn/data-redirect
taty2010 4911dce
Merge branch 'main' into tn/data-redirect
taty2010 25af748
Merge branch 'main' into tn/data-redirect
taty2010 c16f6ce
Merge branch 'main' into tn/data-redirect
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tested this together and it works well. I still have no idea why we have to set the header first, get it and the reset it. If anyone knows why, I'm curious. 🕵🏻