fix: updated redirect data urls #1928
Conversation
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
taty2010
requested review from
nickytonline,
sarahetter,
ascorbic and
orinokai
|
The middleware-redirect test is failing within the PR but not locally. |
| @@ -250,6 +266,12 @@ export const buildResponse = async ({ | |||
| res.headers.set('x-nextjs-redirect', relativizeURL(redirect, request.url)) | |||
| } | |||
|
|
|||
| const nextRedirect = res.headers.get('x-nextjs-redirect') | |||
There was a problem hiding this comment.
We tested this together and it works well. I still have no idea why we have to set the header first, get it and the reset it. If anyone knows why, I'm curious. 🕵🏻
|
Just checking in here @taty2010. Anything else need to be done here or are the test failures valid failures? |
@nickytonline Looks like everything is finally good to go now, the one failing test is the same as before and doesn't seem related to this PR. |
Summary
This update will normalize data redirects
closes #1800
Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.