fix: transform Regex named capture groups for Golang #1809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This was referenced Nov 24, 2022
Closed
ascorbic
reviewed
Nov 24, 2022
Co-authored-by: Matt Kane <[email protected]>
sarahetter
approved these changes
Nov 25, 2022
ascorbic
approved these changes
Nov 29, 2022
|
@orinokai can this be merged? It doesn't rely one edge bundler changes anymore, does it? |
|
currently looking into a failing test ( |
|
Hey @orinokai |
…y/netlify-plugin-nextjs into rs/transform-named-capture-groups
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Quick fix to transform named captured groups in Golang syntax so that edge functions manifests are generated correctly.
Update: PR now simply transforms named capture groups to standard capture groups.
This fix requires the edge-bundler fix linked below before it can be merged.Test plan
The previous failing test
edge-render-getserversidepropsis still failing, but now due to a different issue which is captured in #1890.Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #1794
Requires netlify/edge-bundler#226