Skip to content

[Bug]: edge rendered dynamic routes do not correctly parse slugs into params #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
orinokai opened this issue Jan 18, 2023 · 2 comments · Fixed by #1896
Closed
2 tasks

[Bug]: edge rendered dynamic routes do not correctly parse slugs into params #1890

orinokai opened this issue Jan 18, 2023 · 2 comments · Fixed by #1896
Assignees
Labels
type: bug code to address defects in shipped code

Comments

@orinokai
Copy link
Contributor

Summary

Dynamic routes rendered on the edge with runtime: 'experimental-edge' do not correctly parse the slug into the page parameters.

This is demonstrated by the failing e2e test: edge-render-getserversideprops

Steps to reproduce

  1. Clone the repro and deploy to Netlify
  2. Visit /123?hello=world

Expected: {"url":"/123?hello=world","query": {"hello":"world" ,"id":"123"},"params": {"id":"123"},"now": 1673955487763}

Actual: {"url":"/123?hello=world","query": {"hello":"world"},"now": 1673955487763}

A link to a reproduction repository

https://github.com/orinokai/test-next-edge-slug

Next Runtime version

4.30.0

More information about your build

  • I am building using the CLI
  • I am building using file-based configuration (netlify.toml)

What OS are you using?

None

Your netlify.toml file

No response

Your public/_redirects file

No response

Your next.config.js file

No response

Builds logs (or link to your logs)

No response

Function logs

No response

.next JSON files

No response

@taty2010
Copy link
Contributor

Marc and I were looking into this issue and are needing more info on what's going on. @ascorbic are you already working on this?

@ascorbic
Copy link
Contributor

I started looking at it, and it's a tricky one. It might require edge router

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants