chore: add Next.js e2e tooling #1773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
type: chore
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ascorbic
force-pushed
the
mk/e2e-tooling
branch
2 times, most recently
from
994a1b0 to
1cac95e
Compare
ascorbic
force-pushed
the
mk/e2e-tooling
branch
from
1cac95e to
22a638b
Compare
❌ Deploy Preview for nextjs-plugin-next-11-demo failed.
|
ascorbic
force-pushed
the
mk/e2e-tooling
branch
from
f7e43e2 to
ca1c8e9
Compare
ascorbic
force-pushed
the
mk/e2e-tooling
branch
from
ca1c8e9 to
7dca0cd
Compare
sarahetter
reviewed
Nov 16, 2022
| console.log(`Using Netlify CLI version:`, res.stdout) | ||
| } catch (_) { | ||
| console.log(`Installing Netlify CLI`) | ||
| await execa('npm', ['i', '-g', 'netlify-cli@latest'], { |
There was a problem hiding this comment.
should we use yarn to install this as we're using yarn above?
There was a problem hiding this comment.
This one is a global install, so it doesn't really matter
sarahetter
approved these changes
Nov 16, 2022
sarahetter
approved these changes
Nov 16, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds test tooling to allow us to run e2e tests from the Next.js monorepo. Most of the changes in this PR are files copied from the Next.js monorepo. See next section for details.
Test plan
The following directories do not need reviewing:
test/e2e/getserversideprops: test and fixture site copied from Next.js monorepotest/e2e/next-test-libexcepttest/e2e/next-test-lib/next-modes/next-deploy.tsThis e2e test is failing because it's caught a bug already! Issue: #1776 Fix: #1780
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.