Skip to content

Use nft.json to resolve page dependencies #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ascorbic opened this issue Nov 15, 2022 · 0 comments · Fixed by #1780
Closed

Use nft.json to resolve page dependencies #1776

ascorbic opened this issue Nov 15, 2022 · 0 comments · Fixed by #1780

Comments

@ascorbic
Copy link
Contributor

Currently we use a API route's nft.json files to trace dependencies for the function bundle. However we don't do this for the main handler and ODB functions. For these we instead trace all of the source files. This works in most cases, but means we miss some important files, particularly non-source files.

A good example is this test from #1773, which fails because we're not bundling the static hello.txt, even though it is in the nft.json file.

We should resolve dependencies for all routes in a similar way to how we do them for API routes. This would catch these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants