fix: set undefined ODB 404 TTLs to 60 seconds #1647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-hp-edge-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-export-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-canary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-i18next-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-edge-middleware ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for next-plugin-rsc-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for nextjs-plugin-custom-routes-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for netlify-plugin-nextjs-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
orinokai
force-pushed
the
rs/fix-odb-404
branch
from
167b94c to
b6d5e6b
Compare
ascorbic
approved these changes
Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug that causes 404 responses to be cached indefinitely by ODB functions, meaning that once an ODB route returns a 404 it can never be invalidated by a subsequent 200 response.
The bug occurred because Next Server sends standard cache control headers (SWR, max-age one year) for a 404 response, even if the URL is an ISR route which would otherwise (for a 200 response) send headers with a max age equal to the revalidate value. This means that our handler function was not adding a TTL to the builder function when an ISR page returned a 404.
Standard 404 pages on non-ISR routes will be routed to the standard non-ODB handler function and will therefore bypass the logic in this PR, which should only apply to ISR routes that conditionally return a
notFound: trueingetStaticProps.Test plan
Visit
/getStaticProps/with-revalidate-404/on the demo site deploy preview and observe that the page should 404 if the last digit of the current minute is 0-4 and should show a successful 200 response if the last digit is 5-9.Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Closes netlify/pod-ecosystem-frameworks#246