Skip to content

fix: update ISR pages from 404 responses in Next 11 (DO NOT MERGE) #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

orinokai
Copy link
Contributor

Summary

This PR adds Next 11 support to an earlier fix. The previous fix was only compatible with Next 12 and above.

Test plan

Tests are also being updated to support Next 11 and will follow shortly in a separate PR.

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

chill hedgehogs

@orinokai orinokai requested a review from a team November 17, 2022 10:53
@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit c3bf127
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/63764ca1e4bbac00070f555b
😎 Deploy Preview https://deploy-preview-1784--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo failed.

Name Link
🔨 Latest commit c3bf127
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/63764ca1990ba20008b25204

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit c3bf127
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/63764ca1e25cc900082f962a
😎 Deploy Preview https://deploy-preview-1784--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit c3bf127
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/63764ca13dcff90008baf678
😎 Deploy Preview https://deploy-preview-1784--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit c3bf127
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/63764ca1d90e7b0008e2df20
😎 Deploy Preview https://deploy-preview-1784--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit c3bf127
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/63764ca18642e800083fbb9a
😎 Deploy Preview https://deploy-preview-1784--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit c3bf127
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/63764ca1a6a1d6000ae4a5ed
😎 Deploy Preview https://deploy-preview-1784--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for nextjs-plugin-custom-routes-demo failed.

Name Link
🔨 Latest commit c3bf127
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/63764ca1e4e6c300092fca56

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Nov 17, 2022
@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit c3bf127
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/63764ca1b243670008691dbe
😎 Deploy Preview https://deploy-preview-1784--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for nextjs-plugin-next-11-demo failed.

Name Link
🔨 Latest commit c3bf127
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-next-11-demo/deploys/63764ca1d72c8d0009b9fc6b

@orinokai orinokai marked this pull request as draft November 17, 2022 11:05
@orinokai orinokai changed the title fix: update ISR pages from 404 responses in Next 11 fix: update ISR pages from 404 responses in Next 11 (DO NOT MERGE) Nov 17, 2022
@orinokai orinokai closed this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant