Skip to content

feat: allows disabling function size check #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 25, 2022

Conversation

ericapisani
Copy link

Summary

Replaces #1569

Allows overriding the function bundle size check. This should only be enabled in consultation with someone from the Netlify support team. If enabled, your deployments may break due to exceeding the maximum size limit on the underlying infrastructure that this check is is raising awareness of.

Test plan

Build a site with ntl build and DISABLE_BUNDLE_ZIP_SIZE_CHECK enabled. Should see a warning message about this functionality

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

penguin

@ericapisani ericapisani added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Aug 24, 2022
@ericapisani ericapisani requested a review from minivan August 24, 2022 19:45
@ericapisani ericapisani self-assigned this Aug 24, 2022
@ericapisani ericapisani requested a review from a team August 24, 2022 19:45
@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for netlify-plugin-nextjs-demo ready!

Name Link
🔨 Latest commit d69e7ab
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/6307bf593a238b00080cdad8
😎 Deploy Preview https://deploy-preview-1570--netlify-plugin-nextjs-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for next-hp-edge-demo ready!

Name Link
🔨 Latest commit d69e7ab
🔍 Latest deploy log https://app.netlify.com/sites/next-hp-edge-demo/deploys/6307bf591da3400008331f94
😎 Deploy Preview https://deploy-preview-1570--next-hp-edge-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for netlify-plugin-nextjs-export-demo ready!

Name Link
🔨 Latest commit d69e7ab
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/6307bf59c5b851000966a3db
😎 Deploy Preview https://deploy-preview-1570--netlify-plugin-nextjs-export-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready!

Name Link
🔨 Latest commit d69e7ab
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/6307bf59aeb9d20008433467
😎 Deploy Preview https://deploy-preview-1570--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for next-plugin-rsc-demo ready!

Name Link
🔨 Latest commit d69e7ab
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-rsc-demo/deploys/6307bf591da99e0009ebd1df
😎 Deploy Preview https://deploy-preview-1570--next-plugin-rsc-demo.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for netlify-plugin-nextjs-next-auth-demo ready!

Name Link
🔨 Latest commit d69e7ab
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-next-auth-demo/deploys/6307bf59a3155a0008908143
😎 Deploy Preview https://deploy-preview-1570--netlify-plugin-nextjs-next-auth-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for next-plugin-canary ready!

Name Link
🔨 Latest commit d69e7ab
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-canary/deploys/6307bf5977227b000875288c
😎 Deploy Preview https://deploy-preview-1570--next-plugin-canary.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for next-plugin-edge-middleware ready!

Name Link
🔨 Latest commit d69e7ab
🔍 Latest deploy log https://app.netlify.com/sites/next-plugin-edge-middleware/deploys/6307bf591da3400008331f8f
😎 Deploy Preview https://deploy-preview-1570--next-plugin-edge-middleware.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for nextjs-plugin-custom-routes-demo ready!

Name Link
🔨 Latest commit d69e7ab
🔍 Latest deploy log https://app.netlify.com/sites/nextjs-plugin-custom-routes-demo/deploys/6307bf591da99e0009ebd1e4
😎 Deploy Preview https://deploy-preview-1570--nextjs-plugin-custom-routes-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for netlify-plugin-nextjs-static-root-demo ready!

Name Link
🔨 Latest commit d69e7ab
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/6307bf5940c961000839c61d
😎 Deploy Preview https://deploy-preview-1570--netlify-plugin-nextjs-static-root-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for next-i18next-demo ready!

Name Link
🔨 Latest commit d69e7ab
🔍 Latest deploy log https://app.netlify.com/sites/next-i18next-demo/deploys/6307bf5940c961000839c622
😎 Deploy Preview https://deploy-preview-1570--next-i18next-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

orinokai
orinokai previously approved these changes Aug 25, 2022
Copy link
Contributor

@orinokai orinokai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦑

orinokai
orinokai previously approved these changes Aug 25, 2022
sarahetter
sarahetter previously approved these changes Aug 25, 2022
@ericapisani ericapisani dismissed stale reviews from sarahetter and orinokai via fa21b70 August 25, 2022 18:28
@kodiakhq kodiakhq bot merged commit 6a046de into main Aug 25, 2022
@kodiakhq kodiakhq bot deleted the allow-skipping-of-bundle-size-check branch August 25, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants