chore: allow overriding the check for the bundle size #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for netlify-plugin-nextjs-demo pending review.Visit the deploys page to approve it
|
👷 Deploy request for netlify-plugin-nextjs-export-demo pending review.Visit the deploys page to approve it
|
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 4a27440 |
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 4a27440 |
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 4a27440 |
👷 Deploy request for next-i18next-demo pending review.Visit the deploys page to approve it
|
👷 Deploy request for netlify-plugin-nextjs-nx-monorepo-demo pending review.Visit the deploys page to approve it
|
👷 Deploy request for netlify-plugin-nextjs-static-root-demo pending review.Visit the deploys page to approve it
|
👷 Deploy request for netlify-plugin-nextjs-next-auth-demo pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for next-hp-edge-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -105,6 +105,13 @@ export const checkForRootPublish = ({ | |||
| } | |||
|
|
|||
| export const checkZipSize = async (file: string, maxSize: number = LAMBDA_MAX_SIZE): Promise<void> => { | |||
| // Experimental: We can skip checking for the bundle size on the plugin side. | |||
| // Please reach out to the Netlify support team if you'd like to enable this feature | |||
| if (!process.env.NETLIFY_CHECK_BUNDLE_SIZE) { | |||
There was a problem hiding this comment.
I'd thought this would be the other way around, where you'd set an environment variable if you want to bypass the size check. I don't see anyone going out of their way to enable this variable, so this would effectively amount to disabling the check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Skipping the checks for the bundle size are helpful when folks know what kind of bundles they are uploading to Netlify
🧪 Once merged, make sure to update the version if needed and that it was published correctly.