Skip to content

fix: provide hostname and port to server #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 24, 2022
Merged

fix: provide hostname and port to server #1149

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
70d6714
fix: provide hostname and port
ascorbic Jan 22, 2022
cbe749a
chore: fix cypress
ascorbic Jan 22, 2022
af1ddbb
chore: changes from review
ascorbic Jan 24, 2022
5e31ece
Merge branch 'main' into mk/next-server-host
ascorbic Jan 24, 2022
52968b5
chore: change from review
ascorbic Jan 24, 2022
53cd6c3
chore: lockfile back to v1
ascorbic Jan 24, 2022
2bdc0e7
chore: fix imports
ascorbic Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions cypress/integration/default/preview.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,15 @@ describe('Preview Mode', () => {
cy.findByText('Is preview? No')

// enter preview mode
cy.request('/api/enterPreview').then(
(response) => {
expect(response.body).to.have.property('name', 'preview mode')
}
)
cy.visit('/previewTest')
cy.findByText('Is preview? Yes!')
cy.request('/api/enterPreview').then((response) => {
expect(response.body).to.have.property('name', 'preview mode')
})
cy.visit('/previewTest')
cy.findByText('Is preview? Yes!', { selector: 'h1' })

// exit preview mode
cy.request('/api/exitPreview')
cy.visit('/previewTest')
cy.findByText('Is preview? No')
// exit preview mode
cy.request('/api/exitPreview')
cy.visit('/previewTest')
cy.findByText('Is preview? No', { selector: 'h1' })
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Cypress in CI saying there is more than one instance of this text :confused-capybara:?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was baffled for ages, but if you look at the error in the dashboard, it seems there's a <p>, which is the route announcer (for screen readers)! No idea why it only shows for this route though.

})
})
})
Loading