fix: provide hostname and port to server #1149
Conversation
|
✔️ Deploy Preview for netlify-plugin-nextjs-demo ready! 🔨 Explore the source changes: 2bdc0e7 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61eeb29f5a041c000718bd2d 😎 Browse the preview: https://deploy-preview-1149--netlify-plugin-nextjs-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready! 🔨 Explore the source changes: 2bdc0e7 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61eeb29fc0d22e00079854b0 😎 Browse the preview: https://deploy-preview-1149--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready! 🔨 Explore the source changes: 2bdc0e7 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61eeb29f1b6f3500083a7f8a 😎 Browse the preview: https://deploy-preview-1149--netlify-plugin-nextjs-static-root-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-export-demo ready! 🔨 Explore the source changes: 2bdc0e7 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/61eeb2a0d01a0f0007a19f14 😎 Browse the preview: https://deploy-preview-1149--netlify-plugin-nextjs-export-demo.netlify.app |
ascorbic
force-pushed
the
mk/next-server-host
branch
from
588caa4 to
70d6714
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
ascorbic
changed the title
| // exit preview mode | ||
| cy.request('/api/exitPreview') | ||
| cy.visit('/previewTest') | ||
| cy.findByText('Is preview? No', { selector: 'h1' }) |
There was a problem hiding this comment.
Why is Cypress in CI saying there is more than one instance of this text :confused-capybara:?
There was a problem hiding this comment.
I was baffled for ages, but if you look at the error in the dashboard, it seems there's a <p>, which is the route announcer (for screen readers)! No idea why it only shows for this route though.
|
I changed the indentation level of the handler, so this is easier to review with whitespace hidden |
Summary
As of
[email protected], middleware requiresNextServerto be instantiated with a port and hostname.Test plan
Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Fixes #1141
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.