Skip to content

Performance improvements, improve remote $refs #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Nov 4, 2022

Changes

How to Review

Tests should pass

Checklist

  • Unit tests updated
  • README updated
  • examples/ directory updated (if applicable)

@drwpow drwpow force-pushed the improve-remote-refs branch 10 times, most recently from b05e7b8 to 2788ecb Compare November 7, 2022 06:17
@drwpow drwpow changed the title Improve remote $refs Performance improvements, improve remote $refs Nov 7, 2022
@drwpow drwpow force-pushed the improve-remote-refs branch 19 times, most recently from bfd67c7 to 1930c1b Compare November 8, 2022 23:06
@drwpow drwpow force-pushed the improve-remote-refs branch 2 times, most recently from ac090ef to 4ac7f3b Compare November 9, 2022 00:26
@drwpow drwpow marked this pull request as ready for review November 9, 2022 00:28
@drwpow drwpow force-pushed the improve-remote-refs branch from 4ac7f3b to d1c6a41 Compare November 9, 2022 00:29
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 85.75% // Head: 85.01% // Decreases project coverage by -0.73% ⚠️

Coverage data is based on head (d1c6a41) compared to base (7c5c0d4).
Patch coverage: 69.62% of modified lines in pull request are covered.

❗ Current head d1c6a41 differs from pull request most recent head 0f053ec. Consider uploading reports for the commit 0f053ec to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #971      +/-   ##
==========================================
- Coverage   85.75%   85.01%   -0.74%     
==========================================
  Files          13       13              
  Lines        1320     1395      +75     
  Branches      244      250       +6     
==========================================
+ Hits         1132     1186      +54     
- Misses        188      209      +21     
Impacted Files Coverage Δ
bin/cli.js 81.91% <28.57%> (+1.30%) ⬆️
src/transform/response-object.ts 66.94% <30.76%> (-4.08%) ⬇️
src/utils.ts 80.49% <51.02%> (-3.23%) ⬇️
src/transform/schema-object.ts 87.12% <69.56%> (-1.92%) ⬇️
src/transform/components-object.ts 79.79% <80.00%> (-1.18%) ⬇️
src/transform/request-body-object.ts 97.95% <80.00%> (-2.05%) ⬇️
src/transform/path-item-object.ts 98.27% <83.33%> (+5.41%) ⬆️
src/transform/link-object.ts 100.00% <100.00%> (ø)
src/transform/operation-object.ts 98.11% <100.00%> (+0.11%) ⬆️
src/transform/paths-object.ts 82.05% <100.00%> (-3.37%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@drwpow drwpow force-pushed the improve-remote-refs branch 10 times, most recently from 524b884 to fdf1984 Compare November 9, 2022 03:15
@drwpow drwpow force-pushed the improve-remote-refs branch from fdf1984 to 0f053ec Compare November 9, 2022 03:21
@drwpow drwpow merged commit 903fd34 into main Nov 9, 2022
@drwpow drwpow deleted the improve-remote-refs branch November 9, 2022 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant