Skip to content

requestBody missing content property #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
essential-randomness opened this issue Nov 5, 2022 · 2 comments · Fixed by #971
Closed
1 task done

requestBody missing content property #972

essential-randomness opened this issue Nov 5, 2022 · 2 comments · Fixed by #971
Labels
bug Something isn't working planned Expected in an upcoming version

Comments

@essential-randomness
Copy link

Description

After the refactoring, requestBody is missing content as a nested property. To doublecheck that it is supposed to be there, I tried generating it with the npm version vs the one in github.

NPM version (what I expected):

    requestBody: {
      content: {
        "application/json": {
          /** Format: email */
          email?: string;
          label?: string;
        };
      };
    };

Current version (what I believe is wrong):

    requestBody: {
      "application/json": {
        /** Format: email */
        email?: string;
        label?: string;
      };
    };

Reproduction

Sync with the current codebase and run the generator. Note that the test is also missing this property.

Checklist

@drwpow drwpow added bug Something isn't working planned Expected in an upcoming version labels Nov 5, 2022
@drwpow
Copy link
Contributor

drwpow commented Nov 5, 2022

Thanks so much for taking the time to test the in-progress work! And thanks for being willing to open a PR. But there are some other things changing in the codebase in anticipation of v6 and I wouldn’t want you to deal with that right now so I can make that change. But next time a PR would be very much appreciated! 🙂

@essential-randomness
Copy link
Author

Thank you so much for working on this library :) I was stoked to finally find something that can handle my OpenAPI 3.1 declaration files, and the types have already helped me find a bunch of bugs! Very grateful for the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working planned Expected in an upcoming version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants