-
-
Notifications
You must be signed in to change notification settings - Fork 528
Fixing 'content' being expected to be present. #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing 'content' being expected to be present. #369
Conversation
Codecov Report
@@ Coverage Diff @@
## main #369 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 5 5
Lines 268 268
Branches 90 91 +1
=======================================
Hits 249 249
Misses 13 13
Partials 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix!
I am open to using some library like the one you suggested for the types. At a quick glance, the one suggested does deviate from ours in one area I noticed: it requires paths
. While that does match the schema, we want this library to be more lenient and allow for generation of partial schemas (it’s this project’s goal to generate types, not validate your schema). I haven’t found one yet that meets our needs, but I’m always on the lookout for one.
@all-contributors please add @robertmassaioli for code, bug |
I've put up a pull request to add @robertmassaioli! 🎉 |
Released in |
I spotted that this caused failures for our OpenAPI files being generated.
In general, I think that
OpenAPI3.ts
should be replaced with something like https://www.npmjs.com/package/atlassian-openapi so that the types are more reliable and thus the logic is more correct.