Skip to content

Fixing 'content' being expected to be present. #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

robertmassaioli
Copy link
Contributor

I spotted that this caused failures for our OpenAPI files being generated.

In general, I think that OpenAPI3.ts should be replaced with something like https://www.npmjs.com/package/atlassian-openapi so that the types are more reliable and thus the logic is more correct.

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #369 (7f6b1aa) into main (c41bd90) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files           5        5           
  Lines         268      268           
  Branches       90       91    +1     
=======================================
  Hits          249      249           
  Misses         13       13           
  Partials        6        6           
Impacted Files Coverage Δ
src/v3.ts 96.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e8448...7f6b1aa. Read the comment docs.

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

I am open to using some library like the one you suggested for the types. At a quick glance, the one suggested does deviate from ours in one area I noticed: it requires paths. While that does match the schema, we want this library to be more lenient and allow for generation of partial schemas (it’s this project’s goal to generate types, not validate your schema). I haven’t found one yet that meets our needs, but I’m always on the lookout for one.

@drwpow drwpow merged commit 90c60fc into openapi-ts:main Nov 19, 2020
@drwpow
Copy link
Contributor

drwpow commented Nov 19, 2020

@all-contributors please add @robertmassaioli for code, bug

@allcontributors
Copy link
Contributor

@drwpow

I've put up a pull request to add @robertmassaioli! 🎉

@drwpow
Copy link
Contributor

drwpow commented Nov 19, 2020

Released in 2.4.2! 🚀

nkt added a commit to nkt/openapi-typescript that referenced this pull request Jul 15, 2024
@nkt nkt mentioned this pull request Jul 15, 2024
3 tasks
nkt added a commit to nkt/openapi-typescript that referenced this pull request Jul 15, 2024
nkt added a commit to nkt/openapi-typescript that referenced this pull request Jul 18, 2024
drwpow pushed a commit that referenced this pull request Jul 19, 2024
kerwanp pushed a commit to kerwanp/openapi-typescript that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants