Skip to content

fix: schema.content might be omitted #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

nkt
Copy link
Contributor

@nkt nkt commented Jul 15, 2024

references #369

Changes

There is a case when there is no content in request or response, at the moment openapi-typescript panic in such cases

How to Review

How can a reviewer review your changes? What should be kept in mind for this review?

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@nkt nkt requested a review from a team as a code owner July 15, 2024 12:41
Copy link

changeset-bot bot commented Jul 15, 2024

🦋 Changeset detected

Latest commit: dde937a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nkt nkt force-pushed the fix-optional-content branch from 7b36358 to fc1eb85 Compare July 15, 2024 12:47
@drwpow
Copy link
Contributor

drwpow commented Jul 15, 2024

Great fix, thank you! And great test!

Please add a Changeset that adds a patch to openapi-typescript and I’d be happy to merge and release it.

@nkt nkt force-pushed the fix-optional-content branch from fc1eb85 to dde937a Compare July 18, 2024 10:50
@nkt
Copy link
Contributor Author

nkt commented Jul 18, 2024

@drwpow sorry for delay, done.

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@drwpow drwpow merged commit 19b9383 into openapi-ts:main Jul 19, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Jul 19, 2024
kerwanp pushed a commit to kerwanp/openapi-typescript that referenced this pull request Jul 29, 2024
@nkt nkt deleted the fix-optional-content branch July 29, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants