Skip to content

Fix openapi-fetch benchmarks #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fix openapi-fetch benchmarks #1365

merged 1 commit into from
Oct 5, 2023

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Oct 5, 2023

Changes

Chore: Fix benchmarks. No code changes.

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

⚠️ No Changeset found

Latest commit: 83b30f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 83b30f4
Status: ✅  Deploy successful!
Preview URL: https://79f06d04.openapi-ts.pages.dev
Branch Preview URL: https://fix-benches.openapi-ts.pages.dev

View logs

| openapi-typescript-codegen | `367 kB` | `71k` ops/s (2× slower) |
| Library | Size (min) | “GET” request |
| :------------------------- | ---------: | :------------------------- |
| openapi-fetch | `2 kB` | `200k` ops/s (fastest) |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These probably need a more honest revisit because Vitest’s benchmarking tool seems to still be pretty unreliable. The absolute numbers are pretty dubious (they fluctuate pretty wildly between runs), but the relative numbers seem to be somewhat consistent (whatever the fastest # is, the other numbers seem to be proportionately consistent).

No shenanigans here at all to try and inflate openapi-fetch’s performance metrics. But would like to invest more time in here to produce reproduceable results.

@drwpow drwpow merged commit 1f3fefa into main Oct 5, 2023
@drwpow drwpow deleted the fix-benches branch October 5, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant