chore(openapi-fetch): Improve benchmarks #1897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Part of #1818. #1895 removed MSW from benchmarks, but didn’t get the benchmarks working.
But it seems removing MSW has greatly improved consistency. I’m seeing really consistent runs for openapi-fetch, openapi-fetch (path-based), and openapi-typescript-fetch.
There’s still a missing mock needed for libraries that don’t use
globalThis.fetch
directly (axios, superagent, openapi-typescript-codegen), but that can be handled in a followup.How to Review
pnpm run bench:js
works in openapi-fetchChecklist
N/A