Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

[unused] restructures endpoint data #35

Merged
merged 7 commits into from
Oct 12, 2022
Merged

[unused] restructures endpoint data #35

merged 7 commits into from
Oct 12, 2022

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Oct 7, 2022 •
edited
Loading

  • Restructures endpoint parameter, body + response information
    • Lays the ground work for importing and inheriting parameter schemas from their definitions in path items
  • Turns off schema unaliasing in the python generator because any level of inline schemas are supported
  • path schemas to be defined in RequestPathParameters.Schemas
  • path parameters input typed dict is at RequestPathParameters.Params
  • path parameters for deserilaization at RequestPathParameters.parameters
  • this same pattern is used for RequestPathParameters, RequestQueryParameters, RequestHeaderParameters, RequestBody
    • this prevents schema class name collisions across those data sources
  • endpoint docs improved, now have anchor links to all path/query/header/cookie/body/response definitions + schema definitions

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether marked this pull request as draft October 7, 2022 20:50
@spacether spacether added this to the 2.0.0 milestone Oct 7, 2022
@spacether spacether linked an issue Oct 7, 2022 that may be closed by this pull request
[REQ] restructure endpoint data to allow components/X imports #34
Closed
@spacether spacether changed the title Restructures endpoint parameters and responses, prevents schema collisions Restructures endpoint data, prevents collisions + will allow ref imports in the future Oct 10, 2022
@spacether spacether changed the title Restructures endpoint data, prevents collisions + will allow ref imports in the future Restructures endpoint data Oct 10, 2022
@spacether spacether force-pushed the feat_restructures_parameters branch 2 times, most recently from a79ef05 to e663195 Compare October 11, 2022 19:12
@spacether spacether changed the base branch from master to v_2_0_0_branch October 11, 2022 19:21
@spacether spacether changed the title Restructures endpoint data [v2] Restructures endpoint data Oct 11, 2022
@spacether spacether force-pushed the feat_restructures_parameters branch from e663195 to b0a0170 Compare October 11, 2022 19:27
@spacether spacether mentioned this pull request Oct 11, 2022
Closed
6 tasks
@spacether spacether force-pushed the feat_restructures_parameters branch 2 times, most recently from 3af90e2 to b6fc47f Compare October 11, 2022 20:34
@spacether spacether force-pushed the feat_restructures_parameters branch from b6fc47f to 9057ea1 Compare October 11, 2022 22:28
@spacether spacether marked this pull request as ready for review October 12, 2022 21:40
@spacether spacether merged commit c8b4ab0 into v_2_0_0_branch Oct 12, 2022
@spacether spacether deleted the feat_restructures_parameters branch October 12, 2022 21:44
@spacether spacether changed the title [v2] Restructures endpoint data [v2.0.0] Restructures endpoint data Oct 14, 2022
spacether added a commit that referenced this pull request Oct 18, 2022
@spacether
[v2] Restructures endpoint data (#35)
e76fe9f 
* Restructures endpoint data, modules written for responses

* Endpoint docs improved, not done yet

* Updates header_params

* Updates path_parameters

* Updates cookie_params, updates x_params to say key + input type

* Samples updated

* Fixes DefaultCodegenTests
@spacether spacether changed the title [v2.0.0] Restructures endpoint data v2.0.0 restructures endpoint data Oct 20, 2022
spacether added a commit that referenced this pull request Oct 20, 2022
@spacether
[v2] Restructures endpoint data (#35)
1b44008 
* Restructures endpoint data, modules written for responses

* Endpoint docs improved, not done yet

* Updates header_params

* Updates path_parameters

* Updates cookie_params, updates x_params to say key + input type

* Samples updated

* Fixes DefaultCodegenTests
spacether added a commit that referenced this pull request Oct 26, 2022
@spacether
[v2] Restructures endpoint data (#35)
b2a4959 
* Restructures endpoint data, modules written for responses

* Endpoint docs improved, not done yet

* Updates header_params

* Updates path_parameters

* Updates cookie_params, updates x_params to say key + input type

* Samples updated

* Fixes DefaultCodegenTests
spacether added a commit that referenced this pull request Oct 27, 2022
@spacether
Samples regenerated
ee94685 
[v2] Restructures endpoint data (#35)

* Restructures endpoint data, modules written for responses

* Endpoint docs improved, not done yet

* Updates header_params

* Updates path_parameters

* Updates cookie_params, updates x_params to say key + input type

* Samples updated

* Fixes DefaultCodegenTests

v2.0.0 adds request_body module (#46)

* Java and template updates for separate request body module

* Samples updated

* Samples regenerated

V2.0.0 adds parameter modules, response packages, and response header modules (#47)

* Adds parameter template and code to write it

* Writes module for each parameter

* Removes prependFormOrBodyParameters

* Sample regenrated

* Samples regenerated

* Fixes readme example

* simplifies setting items and additional_properties var names

* Regenerates sample with fixed schema names

* Samples regenerated

* Fixes java docstirng typo

* Fixes JavaModelTest tests

* Fixes tests in JavaModelEnumTest

* FIxes tests in JavaClientCodegenTest

* FIxes tests in DefaultGeneratorTest

* FIxes tests in DefaultCodegenTest

* Adds HeaderParameterWithoutName to api_client

* Sample regenerated, responses are now modules

* Moves request body schemas to the root indentation level of the response modules

* Adds code to generate response header modules

* Updates fromParameter

* Sample updated, fixed bug where form param was not seen as body

* Samples regenerated

* Fixes java tests

2.0.0, moves models into components.schema package (#51)

* python client modelPackage updated

* Fixes links in model_doc template

* Samples updated and python client path methods updated

* Models sucessfully moved into components/schema in one sample

* Replaces model import with components.schema

* Fixes readme imports

* Fixes model doc links from endpoint docs

* Samples regenerated

* Fixes manual test model imports

* Samples regenerated, added init for test components

* Removes model models folders

Changes complexType to refClass (#52)
@spacether spacether restored the feat_restructures_parameters branch October 27, 2022 01:14
@spacether spacether deleted the feat_restructures_parameters branch October 27, 2022 01:28
@spacether
Copy link
Contributor Author

This branch will not be used, 2_0_0 will be used instead

@spacether spacether removed this from the 2.0.0 milestone Oct 27, 2022
@spacether spacether changed the title v2.0.0 restructures endpoint data [unused] restructures endpoint data Oct 27, 2022
@spacether spacether removed a link to an issue Dec 7, 2022
[REQ] restructure endpoint data to allow components/X imports #34
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@spacether