Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

[BUG] Fix endpoint type hint, skip_deserialization=True, when no bodyParam and isOverload = True #39

Closed
6 tasks
spacether opened this issue Oct 11, 2022 · 0 comments · Fixed by #40
Closed
6 tasks
Labels
bug Something isn't working

Comments

@spacether
Copy link
Contributor

Bug Report Checklist

The type hint is missing for this use case

Add this to endpoint_args.handlebars

{{else}}
    {{#if isOverload}}
        {{#eq skipDeserialization "True"}}
    skip_deserialization: typing_extensions.Literal[True],
        {{/eq}}
    {{/if}}
{{/if}}

I noticed this in #35

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request
Description
openapi-json-schema-generator version
OpenAPI declaration file content or url
Generation Details
Steps to reproduce
Related issues/PRs
Suggest a fix
@spacether spacether changed the title [BUG] Fix skip_deserilization input when no bodyParam and isOverload = True [BUG] Fix endpoint type hint, skip_deserialization=True, when no bodyParam and isOverload = True Oct 11, 2022
@spacether spacether linked a pull request Oct 11, 2022 that will close this issue
3 tasks
@spacether spacether added the bug Something isn't working label Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
1 participant