Skip to content

Specify Lower Python Version in Client #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bowenwr opened this issue Dec 3, 2020 · 2 comments
Closed

Specify Lower Python Version in Client #258

bowenwr opened this issue Dec 3, 2020 · 2 comments
Labels
✨ enhancement New feature or improvement
Milestone

Comments

@bowenwr
Copy link
Contributor

bowenwr commented Dec 3, 2020

Is your feature request related to a problem? Please describe.

Perhaps more of a question than request - it looks like the client should be compatible down to Python 3.6. Is there a reason we specify 3.8 in the generated TOML? What do you think about either specifying a lower version or adding a configuration option?

Describe alternatives you've considered

Use a script to overwrite the generated TOML file Python version and target version for Black.

@bowenwr bowenwr added the ✨ enhancement New feature or improvement label Dec 3, 2020
@dbanty
Copy link
Collaborator

dbanty commented Dec 3, 2020

Yes, the reason is I forgot to change the minimum supported version when I added 3.6/7 support 😅

@dbanty dbanty added this to the 0.7.1 milestone Dec 3, 2020
@bowenwr
Copy link
Contributor Author

bowenwr commented Dec 3, 2020

Thanks for such a quick response! Made me feel better I wasn't gaslighting myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants