Skip to content

Commit 42fe727

Browse files
authoredDec 8, 2020
Fixed generated client min Python version (closes #258) (#261)
·
v0.25.00.11.4
1 parent c6dbb36 commit 42fe727

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed
 

‎CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111

1212
### Fixes
1313
- Enums will once again work with query parameters (#259). Thanks @packyg!
14+
- Generated Poetry metadata in pyproject.toml will properly indicate Python 3.6 compatibility (#258). Thanks @bowenwr!
1415

1516
## 0.7.0 - 2020-11-25
1617

‎end_to_end_tests/golden-record-custom/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ include = ["CHANGELOG.md", "custom_e2e/py.typed"]
1313

1414

1515
[tool.poetry.dependencies]
16-
python = "^3.8"
16+
python = "^3.6"
1717
httpx = "^0.15.0"
1818
attrs = "^20.1.0"
1919
python-dateutil = "^2.8.1"

‎end_to_end_tests/golden-record/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ include = ["CHANGELOG.md", "my_test_api_client/py.typed"]
1313

1414

1515
[tool.poetry.dependencies]
16-
python = "^3.8"
16+
python = "^3.6"
1717
httpx = "^0.15.0"
1818
attrs = "^20.1.0"
1919
python-dateutil = "^2.8.1"

‎openapi_python_client/templates/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ include = ["CHANGELOG.md", "{{ package_name }}/py.typed"]
1313

1414

1515
[tool.poetry.dependencies]
16-
python = "^3.8"
16+
python = "^3.6"
1717
httpx = "^0.15.0"
1818
attrs = "^20.1.0"
1919
python-dateutil = "^2.8.1"

3 commit comments

Comments
 (3)

bowenwr commented on Dec 8, 2020

@bowenwr
Contributor

Thanks @dbanty ! Should we also update target_version = ['py38'] to 36 for black?

dbanty commented on Dec 8, 2020

@dbanty
CollaboratorAuthor

As far as I know there's no difference between the two as far as Black is concerned today... but that's not to say a future version won't be even more opinionated. So I added 36, 37, and 38 to both the project's config and the generated configs.

bowenwr commented on Dec 8, 2020

@bowenwr
Contributor

As far as I know there's no difference between the two as far as Black is concerned today... but that's not to say a future version won't be even more opinionated. So I added 36, 37, and 38 to both the project's config and the generated configs.

Thanks for looking into it and as always for being really responsive and an awesome open source maintainer! 🙌

Please sign in to comment.