fix: Namespacesync controller should reconcile an updated namespace #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
approved these changes
Jul 2, 2024
Address feedback
jimmidyson
approved these changes
Jul 3, 2024
supershal
reviewed
Jul 3, 2024
supershal
approved these changes
Jul 3, 2024
Merged
dkoshkin
pushed a commit
that referenced
this pull request
Jul 5, 2024
🤖 I have created a release *beep* *boop* --- ## 0.12.0 (2024-07-05) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Add waiter for object by @dlipovetsky in #777 * feat: Define ServiceLoadBalancer Configuration API by @dlipovetsky in #778 * feat: Use HelmAddon as default addon strategy by @jimmidyson in #771 * feat: Apply MetalLB configuration to remote cluster by @dlipovetsky in #783 * feat: Update addon versions by @jimmidyson in #785 ### Fixes 🔧 * fix: Copy ClusterClasses and Templates without their owner references by @dlipovetsky in #776 * fix: Namespacesync controller should reconcile an updated namespace by @dlipovetsky in #775 * fix: use minimal image when deploying nfd chart by @faiq in #774 ### Other Changes * build: Update release metadata.yaml by @jimmidyson in #768 * ci: Run Nutanix provider e2e tests on self-hosted runner by @jimmidyson in #755 * build: Fix devbox run errors due to piped commands by @jimmidyson in #773 * ci: Fix ct check by @jimmidyson in #779 * build: Use go 1.22.5 toolchain to fix CVE by @jimmidyson in #780 * test(e2e): Use mesosphere fork v1.7.3-d2iq.1 for CAPI providers by @jimmidyson in #781 * ci: Move govulncheck to nightly and push to main triggers by @jimmidyson in #782 * ci: Disable nix cache on self-hosted runners by @jimmidyson in #786 **Full Changelog**: v0.11.2...v0.12.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
The namespacesync controller did not reconcile a namespace when it was updated. We anticipated namespaces to meet the criteria for "target namespace" when they were created. We also wanted to avoid reconciling namespaces unnecessarily.
This PR makes the controller reconcile an updated namespace, if the answer to question "is this a target namespace," has changed. It also adds an integration test (which fails without the subsequent fix commit).
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: