Skip to content

feat: Use HelmAddon as default addon strategy #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

jimmidyson
Copy link
Member

This is properly defaulted by CAPI as can be seen in the Cluster resource when it gets applied (these do not appear in the example cluster manifests):

      variables:
      - name: clusterConfig
        value:
          addons:
            clusterAutoscaler:
              strategy: HelmAddon
            cni:
              provider: Cilium
              strategy: HelmAddon
            csi:
              defaultStorage:
                provider: local-path
                storageClassConfig: default
              providers:
                local-path:
                  storageClassConfigs:
                    default:
                      allowExpansion: false
                      reclaimPolicy: Delete
                      volumeBindingMode: WaitForFirstConsumer
                  strategy: HelmAddon
              snapshotController:
                strategy: HelmAddon
            nfd:
              strategy: HelmAddon

@jimmidyson jimmidyson force-pushed the jimmi/helm-addon-strategy-default branch from 3e5e153 to 5a2e36f Compare July 2, 2024 16:08
@jimmidyson jimmidyson enabled auto-merge (squash) July 2, 2024 16:12
Copy link
Contributor

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jimmidyson jimmidyson merged commit 9039258 into main Jul 3, 2024
27 checks passed
@jimmidyson jimmidyson deleted the jimmi/helm-addon-strategy-default branch July 3, 2024 21:25
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
dkoshkin pushed a commit that referenced this pull request Jul 5, 2024
🤖 I have created a release *beep* *boop*
---


## 0.12.0 (2024-07-05)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: Add waiter for object by @dlipovetsky in
#777
* feat: Define ServiceLoadBalancer Configuration API by @dlipovetsky in
#778
* feat: Use HelmAddon as default addon strategy by @jimmidyson in
#771
* feat: Apply MetalLB configuration to remote cluster by @dlipovetsky in
#783
* feat: Update addon versions by @jimmidyson in
#785
### Fixes 🔧
* fix: Copy ClusterClasses and Templates without their owner references
by @dlipovetsky in
#776
* fix: Namespacesync controller should reconcile an updated namespace by
@dlipovetsky in
#775
* fix: use minimal image when deploying nfd chart by @faiq in
#774
### Other Changes
* build: Update release metadata.yaml by @jimmidyson in
#768
* ci: Run Nutanix provider e2e tests on self-hosted runner by
@jimmidyson in
#755
* build: Fix devbox run errors due to piped commands by @jimmidyson in
#773
* ci: Fix ct check by @jimmidyson in
#779
* build: Use go 1.22.5 toolchain to fix CVE by @jimmidyson in
#780
* test(e2e): Use mesosphere fork v1.7.3-d2iq.1 for CAPI providers by
@jimmidyson in
#781
* ci: Move govulncheck to nightly and push to main triggers by
@jimmidyson in
#782
* ci: Disable nix cache on self-hosted runners by @jimmidyson in
#786


**Full Changelog**:
v0.11.2...v0.12.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants