fix: skip kubeadm CA file when Secret doesn't have a CA #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dkoshkin
force-pushed
the
dkoshkin/fix-registry-wihtout-ca-key
branch
from
aaff4bb to
cb2c6de
Compare
faiq
approved these changes
Jun 27, 2024
Merged
jimmidyson
added a commit
that referenced
this pull request
Jun 27, 2024
🤖 I have created a release *beep* *boop* --- ## 0.11.0 (2024-06-27) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Configure namespace sync in helm chart by @dlipovetsky in #726 * feat: Support CRS for local-path provisioner and add CSI e2e by @jimmidyson in #737 * feat: Support HelmAddon strategy for AWS EBS by @jimmidyson in #732 * feat: Deploy snapshot-controller as separate addon by @jimmidyson in #734 * feat: Update AWS CCM versions and add HelmAddon strategy by @jimmidyson in #748 ### Fixes 🔧 * fix: Namespace Sync controller should list no resources when source namespace is empty string by @dlipovetsky in #725 * fix: Temporarily hard-code supported PC version for Nutanix CSI by @jimmidyson in #751 * fix: skip kubeadm CA file when Secret doesn't have a CA by @dkoshkin in #752 * fix: Correctly report failed deploy of ServiceLoadBalancer by @dlipovetsky in #759 ### Other Changes * build: Tidy up goreleaser config by @jimmidyson in #745 * ci: Fix up image loading for lint-test-helm by @jimmidyson in #746 * refactor: Tidy up Nutanix CSI with consistent apply strategy by @jimmidyson in #733 * test(e2e): Set empty env vars for Nutanix e2e vars by @jimmidyson in #749 * refactor: Use recommended "default" function syntax in helm templates by @dlipovetsky in #750 * refactor: Reusable HelmAddon strategy by @jimmidyson in #735 * test(e2e): Various e2e tests fixes by @jimmidyson in #754 * test(e2e): Correct default helm release names for AWS CCM and EBS CSI by @jimmidyson in #756 **Full Changelog**: v0.10.0...v0.11.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Found a bug when testing with a mirror registry where it doesn't have the CA key set in the Secret.
The handler incorrectly generated a patch to add
/etc/certs/...file with a Secret source and keyca.crt, however its possible that the Secret does not have that key set.Example of an incorrect file:
This led to CAPI failing because
ca.crtdid not exist in the Secret.Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
The first commit contains a failing unit tests to cover this scenario.
Special notes for your reviewer: