feat: Support HelmAddon strategy for AWS EBS #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
force-pushed
the
jimmi/local-path-csi-strategy
branch
from
6a83356 to
e329d92
Compare
jimmidyson
force-pushed
the
jimmi/aws-ebs-csi-strategy
branch
3 times, most recently
from
46f40ea to
c91fd70
Compare
jimmidyson
force-pushed
the
jimmi/local-path-csi-strategy
branch
from
e329d92 to
6758933
Compare
Base automatically changed from
jimmi/local-path-csi-strategy
to
jimmi/cluster-api-1.7.3-d2iq.0
June 20, 2024 17:11
jimmidyson
force-pushed
the
jimmi/cluster-api-1.7.3-d2iq.0
branch
from
bb98508 to
0b7375e
Compare
jimmidyson
force-pushed
the
jimmi/aws-ebs-csi-strategy
branch
from
c91fd70 to
df37085
Compare
jimmidyson
changed the base branch from
jimmi/cluster-api-1.7.3-d2iq.0
to
jimmi/local-path-csi-strategy
dkoshkin
previously approved these changes
Jun 20, 2024
supershal
reviewed
Jun 21, 2024
supershal
previously approved these changes
Jun 21, 2024
jimmidyson
force-pushed
the
jimmi/aws-ebs-csi-strategy
branch
from
df37085 to
71b92d2
Compare
jimmidyson
force-pushed
the
jimmi/local-path-csi-strategy
branch
from
0ee9348 to
e02c655
Compare
jimmidyson
force-pushed
the
jimmi/aws-ebs-csi-strategy
branch
from
71b92d2 to
1315c65
Compare
jimmidyson
force-pushed
the
jimmi/local-path-csi-strategy
branch
from
e02c655 to
7aa8b34
Compare
jimmidyson
force-pushed
the
jimmi/aws-ebs-csi-strategy
branch
2 times, most recently
from
5869295 to
f2628f9
Compare
jimmidyson
force-pushed
the
jimmi/local-path-csi-strategy
branch
from
7aa8b34 to
ef05b88
Compare
jimmidyson
dismissed stale reviews from supershal and dkoshkin
The base branch was changed.
|
This PR/issue depends on:
|
Also add e2e tests for AWS EBS deployment.
jimmidyson
force-pushed
the
jimmi/aws-ebs-csi-strategy
branch
from
f2628f9 to
68020de
Compare
dkoshkin
approved these changes
Jun 26, 2024
mhrabovcin
approved these changes
Jun 26, 2024
Merged
jimmidyson
added a commit
that referenced
this pull request
Jun 26, 2024
Move the current logic out to a helm addon strategy as done in other providers. Also move Helm release to kube-system to be consistent with other CSI providers. And tidy up flag names to use `--csi.nutanix.` prefix for flags, including wiring up to Helm chart values and deployment. Finally, add e2e test for CSI deployment in Nutanix infra. Depends on #732. --------- Co-authored-by: Dimitri Koshkin <[email protected]>
jimmidyson
added a commit
that referenced
this pull request
Jun 27, 2024
🤖 I have created a release *beep* *boop* --- ## 0.11.0 (2024-06-27) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Configure namespace sync in helm chart by @dlipovetsky in #726 * feat: Support CRS for local-path provisioner and add CSI e2e by @jimmidyson in #737 * feat: Support HelmAddon strategy for AWS EBS by @jimmidyson in #732 * feat: Deploy snapshot-controller as separate addon by @jimmidyson in #734 * feat: Update AWS CCM versions and add HelmAddon strategy by @jimmidyson in #748 ### Fixes 🔧 * fix: Namespace Sync controller should list no resources when source namespace is empty string by @dlipovetsky in #725 * fix: Temporarily hard-code supported PC version for Nutanix CSI by @jimmidyson in #751 * fix: skip kubeadm CA file when Secret doesn't have a CA by @dkoshkin in #752 * fix: Correctly report failed deploy of ServiceLoadBalancer by @dlipovetsky in #759 ### Other Changes * build: Tidy up goreleaser config by @jimmidyson in #745 * ci: Fix up image loading for lint-test-helm by @jimmidyson in #746 * refactor: Tidy up Nutanix CSI with consistent apply strategy by @jimmidyson in #733 * test(e2e): Set empty env vars for Nutanix e2e vars by @jimmidyson in #749 * refactor: Use recommended "default" function syntax in helm templates by @dlipovetsky in #750 * refactor: Reusable HelmAddon strategy by @jimmidyson in #735 * test(e2e): Various e2e tests fixes by @jimmidyson in #754 * test(e2e): Correct default helm release names for AWS CCM and EBS CSI by @jimmidyson in #756 **Full Changelog**: v0.10.0...v0.11.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add e2e tests for AWS EBS deployment.
As we do not have e2e test runs for AWS in CI right now I have manually run the e2e locally and it worked.
Depends on #737.