feat: Support CRS for local-path provisioner and add CSI e2e #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
force-pushed
the
jimmi/local-path-csi-strategy
branch
from
442f2ef to
6a83356
Compare
jimmidyson
force-pushed
the
jimmi/local-path-csi-strategy
branch
from
6a83356 to
e329d92
Compare
|
why do we need crs support for this? |
This is more about adding consistency across addons/providers - what i'd really like to do is remove all CRS installations. |
dkoshkin
approved these changes
Jun 20, 2024
dkoshkin
approved these changes
Jun 20, 2024
Further strategy support for other providers coming in follow up PR, plus more e2e tests for those other providers.
jimmidyson
force-pushed
the
jimmi/local-path-csi-strategy
branch
from
e329d92 to
6758933
Compare
|
This PR/issue depends on:
|
jimmidyson
merged commit bb98508
into
jimmi/cluster-api-1.7.3-d2iq.0
18 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further strategy support for other providers coming in follow up PR,
plus more e2e tests for those other providers.
Blocked by #736.