fix: CredentialProviderConfig matchImages to support registries with port

[dkoshkin]

What problem does this PR solve?:
While debugging another issue where I launched a local registry in a container at https://172.18.0.10:5000, I noticed that Deployments with an image in that registry failed:

  Warning  Failed     7m14s (x4 over 8m47s)   kubelet            Failed to pull image "172.18.0.10:5000/library/nginx:latest": failed to pull and unpack image "172.18.0.10:5000/library/nginx:latest": failed to resolve reference "172.18.0.10:5000/library/nginx:latest": pull access denied, repository does not exist or may require authorization: authorization failed: no basic auth credentials

This is because of a bug in how matchImages in CredentialProviderConfig was generated, the globs don't match images with a port or a path. This PR fixes that by explicitly including the user provided registries in matchImages.

Which issue(s) this PR fixes:
Fixes #

How Has This Been Tested?:

• Updated unit tests

Special notes for your reviewer:

[jimmidyson]

@dkoshkin I can't see - does this include the mirror registry? It will also need to be in the matchImages

[dkoshkin]

@dkoshkin I can't see - does this include the mirror registry? It will also need to be in the matchImages

Yes @jimmidyson, eventually this function gets called here, where registriesWithOptionalCredentials contains the registries from both vars imageRegistries and globalMirror

cluster-api-runtime-extensions-nutanix/pkg/handlers/generic/mutation/imageregistries/credentials/inject.go

Lines 148 to 151 in 2183f8f

	files, commands, generateErr := generateFilesAndCommands(
	registriesWithOptionalCredentials,
	clusterKey.Name,
	)

Just tested locally too:

Setting either one:

        imageRegistries:
        - credentials:
            secretRef:
              name: docker-creds-1-image-registry-mirror-credentials
          url: https://172.18.0.10:5000

        globalImageRegistryMirror:
          credentials:
            secretRef:
              name: docker-creds-1-image-registry-mirror-credentials
          url: https://172.18.0.10:5000

Generated config:

    - content: |
        apiVersion: kubelet.config.k8s.io/v1
        kind: CredentialProviderConfig
        providers:
        - name: dynamic-credential-provider
          args:
          - get-credentials
          - -c
          - /etc/kubernetes/dynamic-credential-provider-config.yaml
          matchImages:
          - "172.18.0.10:5000"
          - "*"
          - "*.*"
          - "*.*.*"
          - "*.*.*.*"
          - "*.*.*.*.*"
          - "*.*.*.*.*.*"
          defaultCacheDuration: "0s"
          apiVersion: credentialprovider.kubelet.k8s.io/v1
      path: /etc/kubernetes/image-credential-provider-config.yaml
      permissions: "0600"