Skip to content

fix: set ownerReference on imageRegistry and globalMirror Secrets #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 17, 2024
Merged

fix: set ownerReference on imageRegistry and globalMirror Secrets #720

merged 7 commits into from
Jun 17, 2024

Conversation

dkoshkin
Copy link
Contributor

What problem does this PR solve?:
Add ownerReference to user provided credentials Secrets for imageRegistry and globalMirror variables. These Secrets will now be moved with clusterctl move and deleted once the Cluster is deleted.

I needed EnsureOwnerRefForSecret from the lifecycleutils package but that function needed alot of other functions from that package, so moved it all up the handlers package. (first commit)

Which issue(s) this PR fixes:
Fixes https://jira.nutanix.com/browse/NCN-100641

How Has This Been Tested?:

Added unit tests and tested manually for both imageRegistry and globalMirror:

$ kubectl get secret dkoshkin-registry-creds-owner-ref-1-dockerhub-credentials -o yaml
apiVersion: v1
data:
  password: <>
  username: <>
kind: Secret
metadata:
  creationTimestamp: "2024-06-13T23:47:59Z"
  labels:
    cluster.x-k8s.io/provider: nutanix
  name: dkoshkin-registry-creds-owner-ref-1-dockerhub-credentials
  namespace: default
  ownerReferences:
  - apiVersion: cluster.x-k8s.io/v1beta1
    kind: Cluster
    name: dkoshkin-registry-creds-owner-ref-1
    uid: be432689-315c-4511-a294-f397b3cdb9b7
  resourceVersion: "3886"
  uid: 84366a22-63db-4820-bf31-b5bf36e2c6cb
type: Opaque

Special notes for your reviewer:

@dkoshkin dkoshkin self-assigned this Jun 14, 2024
@github-actions github-actions bot added the fix label Jun 14, 2024
@dkoshkin dkoshkin force-pushed the dkoshkin/fix-add-owner-ref-registry-secrets branch from 1b20a86 to 9b0ef31 Compare June 14, 2024 02:43
@dkoshkin dkoshkin force-pushed the dkoshkin/fix-add-owner-ref-registry-secrets branch 3 times, most recently from ffda93c to edaf1fe Compare June 14, 2024 03:12
supershal
supershal approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@supershal supershal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and test.

@dkoshkin dkoshkin force-pushed the dkoshkin/fix-add-owner-ref-registry-secrets branch from fc26132 to b356179 Compare June 17, 2024 21:33
@dkoshkin dkoshkin force-pushed the dkoshkin/fix-add-owner-ref-registry-secrets branch from b356179 to 3399f10 Compare June 17, 2024 21:45
@dkoshkin dkoshkin merged commit 96e49a3 into main Jun 17, 2024
17 checks passed
@dkoshkin dkoshkin deleted the dkoshkin/fix-add-owner-ref-registry-secrets branch June 17, 2024 23:05
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
Merged
faiq pushed a commit that referenced this pull request Jun 24, 2024
@jimmidyson @github-actions
release(main): v0.10.0 (#685)
2d2a3f7 
🤖 I have created a release *beep* *boop*
---


## 0.10.0 (2024-06-24)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: Upgrade to Cilium v1.15.5 by @jimmidyson in
#689
* feat: Upgrade to Calico v3.28.0 by @jimmidyson in
#688
* feat: bumps caaph to v0.2.3 by @faiq in
#691
* feat: Add local-path-provisioner CSI by @jimmidyson in
#693
* feat: cluster-api v1.7.3 by @jimmidyson in
#714
* feat: bumps caaph to 0.2.4 by @faiq in
#718
* feat: Controller that copies ClusterClasses to namespaces by
@dlipovetsky in
#715
* feat: adds a mindthegap container and deployment by @faiq in
#637
* feat: implements BeforeClusterUpgrade hook by @faiq in
#682
### Fixes 🔧
* fix: use external Nutanix API types directly by @dkoshkin in
#698
* fix: Post-process clusterconfig CRDs for supported CSI providers by
@jimmidyson in
#695
* fix: nutanix credentials Secrets owner refs by @dkoshkin in
#711
* fix: credential provider response secret ownership by @dkoshkin in
#709
* fix: static credentials Secret generation by @dkoshkin in
#717
* fix: set ownerReference on imageRegistry and globalMirror Secrets by
@dkoshkin in
#720
* fix: Allow Nutanix CSI snapshot controller & webhook to run on CP
nodes by @dlipovetsky in
#723
* refactor: Use maps for CSI providers and storage classes by
@jimmidyson in
#696
* fix: CredentialProviderConfig matchImages to support registries with
port by @dkoshkin in
#724
* fix: Allow Node Feature Discovery garbage collector to run on
control-plane nodes by @dlipovetsky in
#722
* fix: RBAC role for namespace-sync controller to watch,list namespaces
by @dkoshkin in
#738
* fix: image registries not handling CA certificates by @dkoshkin in
#729
* fix: adds a docker buildx step before release-snapshot by @faiq in
#741
### Other Changes
* docs: Add released version to helm and clusterctl install by
@jimmidyson in
#683
* revert: Temporary lint config fix until next golangci-lint release
(#629) by @jimmidyson in
#686
* refactor: Delete unused code by @jimmidyson in
#687
* refactor: Reduce log verbosity for skipped handlers by @jimmidyson in
#692
* build: update Go to 1.22.4 by @dkoshkin in
#700
* build(deps): Upgrade CAPX version to v1.4.0 by @thunderboltsid in
#707
* build: Move CSI supported provider logic to script by @jimmidyson in
#703
* build: Add testifylint linter by @jimmidyson in
#706
* build: Update all tools by @jimmidyson in
#704
* refactor: rename credential provider response secret by @dkoshkin in
#710
* refactor: Simplify code by using slices.Clone by @jimmidyson in
#712
* refactor: consistently use the same SetOwnerReference function by
@dkoshkin in
#713
* refactor: kube-vip commands by @dkoshkin in
#699
* build: Fix an incorrect make variable passed to goreleaser by
@dlipovetsky in
#716
* build: Add 'chart-docs' make target by @dlipovetsky in
#727
* build: Make CAREN mindthegap reg multiarch by @jimmidyson in
#730
* Add helm values schema plugin by @dlipovetsky in
#728
* test(e2e): Use mesosphere fork with CRSBinding fix by @jimmidyson in
#736

## New Contributors
* @thunderboltsid made their first contribution in
#707

**Full Changelog**:
v0.9.0...v0.10.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmidyson jimmidyson jimmidyson approved these changes

@dlipovetsky dlipovetsky dlipovetsky approved these changes

@supershal supershal supershal approved these changes

@faiq faiq Awaiting requested review from faiq

Assignees

@dkoshkin dkoshkin

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkoshkin @jimmidyson @dlipovetsky @supershal