feat: Sync up from d2iq-labs fork #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed when reorganising example kustomizations in previous PR.
Without this, defaults declared in the JSON schema are not included in validation steps, which can lead to invalid failures, while also not allowing for tests that target defaults.
Co-authored-by: Faiq <[email protected]> Signed-off-by: Deepak Muley <[email protected]>
Also deploy infra provider versions that match the API.
CPI is a term unique to the vSphere CCM. Renaming to the more generic "CCM".
Other patches can change the slice length, causing the previous check to fail, although all correct patches are present.
Other patches can change the slice length, causing the previous check to fail, although all correct patches are present.
* fix: update latest template * build: pin commit for nutanix examples
- Defines a cluster-level variable for defining one or more users - Patches bootstrap templates for control plane and worker node pools with user configuration
Address review comments
Expand comments
Fix typo in lockPassword logic, and add unit test
Add unit test for empty hashed password
Change Sudo field from pointer to value The zero value (empty string) is not valid, so the field does not need to be a pointer.
Make username required
Explain why we do not validate hashed password input
Explain why we do not validate sudo input
Update type comments
Remove errant comment
* refactor: combine PC host and port into a single url var This makes it simpler for clients to provide a single input field and not have to do any parsing to split the hostname and port. It also allows us to use API validation for bad input. * fixup! refactor: combine PC host and port into a single url var * fixup! refactor: combine PC host and port into a single url var * fixup! refactor: combine PC host and port into a single url var
The existing code created a ClusterResourceSet with the user provided Secret. However, that won't work unless that Secret has an embedded Secret in it.
* ci: adds tooling to create configmap * feat: use a configmap to get helmchart info * fix: precommit issues * fix: typo in cilium * fix: remove workspace files * build: template name for configmap * refactor: names for helm chart info getter * refactor: use nutanix-storage name instead of nutnaix-csi * refactor: move to globaloptions * fix: adds snapshot to helm config * fix: comments after review * fix: adds a warning and removes ebs csi * fix: typo * fix: adds missing script file * fix: precommit
* feat: Add patch to configure containerd metrics
This makes the deployment consistent as well as avoiding issues when providers are in the middle of a release.
* build: remove nutanix CCM from examples * build: add scripts to sync Nutanix CCM manifests * build: add CCM addon var to Nutanix examples * feat: deploy Nutanix CCM addon Aligns the method of deploying the CCM with all other addons. * fixup! build: add scripts to sync Nutanix CCM manifests * fixup! feat: deploy Nutanix CCM addon * build: remove unused CRS tooling for Nutanix CCM The CRS strategy is not supported for the Nutanix CCM, removing it until we actually need it.
jimmidyson
requested review from
dlipovetsky,
dkoshkin,
faiq,
thunderboltsid,
supershal and
deepakm-ntnx
mikolajb
approved these changes
Apr 11, 2024
mhrabovcin
approved these changes
Apr 11, 2024
auto-merge was automatically disabled
April 11, 2024 09:08
Base branch requires signed commits
Merged
jimmidyson
pushed a commit
that referenced
this pull request
Apr 15, 2024
🤖 I have created a release *beep* *boop* --- ## 0.7.0 (2024-04-15) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Sync up from d2iq-labs fork by @jimmidyson in #489 * feat: set default instance profile for AWS CP and worker nodes by @supershal in #506 ### Fixes 🔧 * fix: set defaults for AWS CP and Worker instanceType by @supershal in #504 ### Other Changes * build: Remove unused tool crane by @jimmidyson in #459 * ci: Add govulncheck check by @jimmidyson in #461 * ci: Remove auto-approve PR steps by @jimmidyson in #462 * build: Tidy up examples sync script by @jimmidyson in #458 * test: Remove redundant test case from httpproxy handler by @dlipovetsky in #463 * ci: Fix pages workflow concurrency by @jimmidyson in #493 * refactor: Replace direct usage of CAAPH API with vendored types by @jimmidyson in #492 * refactor: Update module paths to use nutanix-cloud-native GH org by @jimmidyson in #494 * build: Remove unused capbk and capd hack modules by @jimmidyson in #496 * docs: add pull request template for the repository by @supershal in #502 * docs: Add file extension to containerd-metrics doc by @dlipovetsky in #503 * build: set dockerhub credentials for Nutanix examples by @dkoshkin in #501 **Full Changelog**: v0.6.0...v0.7.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged as
rebase and merge, notsquashormerge commit.