This repository was archived by the owner on Apr 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
961ee09
to
ef132d9
Compare
ab52d33
to
764761c
Compare
b7bea8f
to
ee58bbd
Compare
faiq
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
supershal
reviewed
Apr 10, 2024
supershal
reviewed
Apr 10, 2024
supershal
reviewed
Apr 10, 2024
...-api-runtime-extensions-nutanix/templates/ccm/nutanix/manifests/helm-addon-installation.yaml
Outdated
Show resolved
Hide resolved
supershal
reviewed
Apr 10, 2024
...-api-runtime-extensions-nutanix/templates/ccm/nutanix/manifests/helm-addon-installation.yaml
Show resolved
Hide resolved
faiq
reviewed
Apr 10, 2024
faiq
reviewed
Apr 10, 2024
Aligns the method of deploying the CCM with all other addons.
The CRS strategy is not supported for the Nutanix CCM, removing it until we actually need it.
abde55d
to
5e41c8f
Compare
supershal
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
jimmidyson
pushed a commit
that referenced
this pull request
Apr 11, 2024
* build: remove nutanix CCM from examples * build: add scripts to sync Nutanix CCM manifests * build: add CCM addon var to Nutanix examples * feat: deploy Nutanix CCM addon Aligns the method of deploying the CCM with all other addons. * fixup! build: add scripts to sync Nutanix CCM manifests * fixup! feat: deploy Nutanix CCM addon * build: remove unused CRS tooling for Nutanix CCM The CRS strategy is not supported for the Nutanix CCM, removing it until we actually need it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on dkoshkin/fix-nutanix-csi
This PR removes the Nutanix CCM from the templates and instead deploys it using CAAPH using the published Helm chart.
https://d2iq.atlassian.net/browse/D2IQ-99841