Skip to content

feat: go 1.24.1 and update all other tools #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Conversation

jimmidyson
Copy link
Member

Also includes some enhancements to testing (t.Context) highlighted
by golangci-lint.

Also includes some enhancements to testing (t.Context) highlighted
by golangci-lint.
@jimmidyson jimmidyson enabled auto-merge (squash) March 5, 2025 11:05
@dkoshkin
Copy link
Contributor

dkoshkin commented Mar 5, 2025

This is what I see when using the commit from this PR in a different repo. The build still worked with Go go1.23.6 though.

Executing target: go-mod-tidy
go: downloading github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/api v0.27.2-0.20250305155111-43f67808c340
go: github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/[email protected] requires go >= 1.24; switching to go1.24.1
go: downloading go1.24.1 (darwin/arm64)

@jimmidyson
Copy link
Member Author

This is what I see when using the commit from this PR in a different repo. The build still worked with Go go1.23.6 though.

Executing target: go-mod-tidy
go: downloading github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/api v0.27.2-0.20250305155111-43f67808c340
go: github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/[email protected] requires go >= 1.24; switching to go1.24.1
go: downloading go1.24.1 (darwin/arm64)

@dkoshkin Can you try again please? Reverted language compatibility.

Copy link
Contributor

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, downstream projects can continue to use Go 1.23 with the fixup

@jimmidyson jimmidyson merged commit a331535 into main Mar 7, 2025
24 checks passed
@jimmidyson jimmidyson deleted the jimmi/go-1.24.1 branch March 7, 2025 16:42
faiq pushed a commit that referenced this pull request Apr 10, 2025
🤖 I have created a release *beep* *boop*
---


## 0.28.0 (2025-04-10)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: Update all addon versions by @jimmidyson in
#1054
* feat: go 1.24.1 and update all other tools by @jimmidyson in
#1066
* feat: bumped frr-routing to 9.1.3 by @ArvinderPal09 in
#1067
* feat: properly support kube-vip upgrades by @dkoshkin in
#1062
* feat: update addons by @dkoshkin in
#1072
* feat: enable Cilium's hubble relay mTLS by @dkoshkin in
#1086
* feat: adds image tempalting for capx by @faiq in
#1096
* feat: support setting kubeadm ignorePreflightErrors by @dkoshkin in
#1097
* feat: go 1.24.2 to fix CVE by @jimmidyson in
#1100
* feat: update Calico to v3.29.3 by @dkoshkin in
#1101
### Fixes 🔧
* fix: correctly handle multiple registries with the same Host by
@dkoshkin in
#1063
* fix: Tolerate all NoSchedule taints for NFD and CSI deployments by
@jimmidyson in
#1074
* fix: Retain existing join and init kubeadm config when adding taints
by @jimmidyson in
#1073
### Other Changes
* build: Update k8s versions for tests by @jimmidyson in
#1052
* docs: updates cilium doc with link to its default spec by
@manoj-nutanix in
#1036
* ci: Replace deprecated blackduck scan action by @jimmidyson in
#1070
* build: Update k8s.io/{kubelet,utils} deps by @jimmidyson in
#1078
* revert: "build: Update k8s.io/{kubelet,utils} deps" by @jimmidyson in
#1080
* ci: Enable dependabot for hack/tools module by @jimmidyson in
#1082
* build: Update k8s.io/kubelet dep by @jimmidyson in
#1081
* ci: Use Kubernetes minor in e2e check name by @jimmidyson in
#1090

## New Contributors
* @ArvinderPal09 made their first contribution in
#1067

**Full Changelog**:
v0.27.1...v0.28.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dimitri Koshkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants