fixup! build: Revert language compatibility to 1.23

Author: jimmidyson

.golangci.yml

@@ -5,6 +5,7 @@ run:
   timeout: 10m
   build-tags:
     - e2e
+  go: "1.23"
 
 linters:
   disable-all: true

api/go.mod

@@ -3,7 +3,7 @@
 
 module github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/api
 
-go 1.24
+go 1.23
 
 toolchain go1.24.1
 

common/go.mod

@@ -3,7 +3,7 @@
 
 module github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/common
 
-go 1.24
+go 1.23
 
 toolchain go1.24.1
 

common/pkg/capi/clustertopology/handlers/lifecycle/parallel_test.go

@@ -248,7 +248,7 @@ func Test_runHooksInParallel(t *testing.T) {
 
 			gotResponse := &runtimehooksv1.BeforeClusterUpgradeResponse{}
 			runHooksInParallel(
-				t.Context(),
+				context.Background(),
 				hookFuncs,
 				&runtimehooksv1.BeforeClusterUpgradeRequest{},
 				gotResponse,

common/pkg/capi/clustertopology/handlers/mutation/meta_test.go

@@ -223,7 +223,7 @@ func TestMetaGeneratePatches(t *testing.T) {
 			h := NewMetaGeneratePatchesHandler("", nil, tt.mutaters...).(GeneratePatches)
 
 			resp := &runtimehooksv1.GeneratePatchesResponse{}
-			h.GeneratePatches(t.Context(), &runtimehooksv1.GeneratePatchesRequest{
+			h.GeneratePatches(context.Background(), &runtimehooksv1.GeneratePatchesRequest{
 				Items: []runtimehooksv1.GeneratePatchesRequestItem{
 					request.NewKubeadmConfigTemplateRequestItem("kubeadm-config"),
 					request.NewKubeadmControlPlaneTemplateRequestItem("kubeadm-control-plane"),

common/pkg/testutils/capitest/variables.go

@@ -4,6 +4,7 @@
 package capitest
 
 import (
+	"context"
 	"encoding/json"
 	"testing"
 
@@ -40,7 +41,7 @@ func ValidateDiscoverVariables[T mutation.DiscoverVariables](
 	h := handlerCreator()
 	resp := &runtimehooksv1.DiscoverVariablesResponse{}
 	h.DiscoverVariables(
-		t.Context(),
+		context.Background(),
 		&runtimehooksv1.DiscoverVariablesRequest{},
 		resp,
 	)

go.mod

@@ -3,7 +3,7 @@
 
 module github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix
 
-go 1.24
+go 1.23
 
 toolchain go1.24.1
 

pkg/handlers/generic/lifecycle/csi/handler_test.go

@@ -155,7 +155,7 @@ func Test_AfterControlPlaneInitialized(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			ctx := t.Context()
+			ctx := context.Background()
 			client := fake.NewClientBuilder().Build()
 			handler := New(client, testProviderHandlers)
 			resp := &runtimehooksv1.AfterControlPlaneInitializedResponse{}

pkg/handlers/generic/lifecycle/servicelbgc/deleter_test.go

@@ -4,6 +4,7 @@
 package servicelbgc
 
 import (
+	"context"
 	"testing"
 
 	"github.com/go-logr/logr"
@@ -203,13 +204,17 @@ func Test_deleteServicesWithLoadBalancer(t *testing.T) {
 				svc := &tt.startServices[i]
 				require.NoError(
 					t,
-					fakeClient.Create(t.Context(), svc),
+					fakeClient.Create(context.Background(), svc),
 					"error creating Service",
 				)
 			}
 
 			for {
-				err := deleteServicesWithLoadBalancer(t.Context(), fakeClient, logr.Discard())
+				err := deleteServicesWithLoadBalancer(
+					context.Background(),
+					fakeClient,
+					logr.Discard(),
+				)
 				if err == nil {
 					break
 				}
@@ -224,7 +229,7 @@ func Test_deleteServicesWithLoadBalancer(t *testing.T) {
 			services := &corev1.ServiceList{}
 			require.NoError(
 				t,
-				fakeClient.List(t.Context(), services),
+				fakeClient.List(context.Background(), services),
 				"error listing Services",
 			)
 			assert.Equal(t, tt.endServices, services.Items)

pkg/handlers/generic/lifecycle/serviceloadbalancer/handler_test.go

@@ -124,7 +124,7 @@ func testCases(t *testing.T) []testCase {
 func TestAfterControlPlaneInitialized(t *testing.T) {
 	for _, tt := range testCases(t) {
 		t.Run(tt.name, func(t *testing.T) {
-			ctx := t.Context()
+			ctx := context.Background()
 			client := fake.NewClientBuilder().Build()
 			handler := New(client, testProviderHandlers)
 			resp := &runtimehooksv1.AfterControlPlaneInitializedResponse{}
@@ -156,7 +156,7 @@ func TestAfterControlPlaneInitialized(t *testing.T) {
 func TestBeforeClusterUpgrade(t *testing.T) {
 	for _, tt := range testCases(t) {
 		t.Run(tt.name, func(t *testing.T) {
-			ctx := t.Context()
+			ctx := context.Background()
 			client := fake.NewClientBuilder().Build()
 			handler := New(client, testProviderHandlers)
 			resp := &runtimehooksv1.BeforeClusterUpgradeResponse{}

pkg/handlers/generic/mutation/controlplanevirtualip/providers/kubevip_test.go

@@ -4,6 +4,7 @@
 package providers
 
 import (
+	"context"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -191,7 +192,7 @@ func Test_GenerateFilesAndCommands(t *testing.T) {
 			}
 
 			files, preKubeadmCommands, postKubeadmCommands, err := provider.GenerateFilesAndCommands(
-				t.Context(),
+				context.Background(),
 				tt.controlPlaneEndpointSpec,
 				tt.cluster,
 			)
@@ -271,7 +272,7 @@ func Test_getTemplateFromConfigMap(t *testing.T) {
 			fakeClient := fake.NewClientBuilder().WithObjects(tt.configMap).Build()
 
 			data, err := getTemplateFromConfigMap(
-				t.Context(),
+				context.Background(),
 				fakeClient,
 				client.ObjectKeyFromObject(tt.configMap),
 			)

pkg/handlers/utils/secrets_test.go

@@ -4,6 +4,7 @@
 package utils
 
 import (
+	"context"
 	"fmt"
 	"testing"
 
@@ -114,7 +115,7 @@ func Test_EnsureOwnerReferenceForSecret(t *testing.T) {
 			t.Parallel()
 
 			err := EnsureClusterOwnerReferenceForObject(
-				t.Context(),
+				context.Background(),
 				tt.client,
 				corev1.TypedLocalObjectReference{
 					Kind: "Secret",
@@ -133,7 +134,7 @@ func Test_EnsureOwnerReferenceForSecret(t *testing.T) {
 			// verify that the owner reference was added
 			secret := &corev1.Secret{}
 			err = tt.client.Get(
-				t.Context(),
+				context.Background(),
 				client.ObjectKey{Namespace: tt.cluster.Namespace, Name: tt.secretName},
 				secret,
 			)

pkg/wait/wait_test.go

@@ -166,7 +166,7 @@ func TestWait(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			err := ForObject(
-				t.Context(),
+				context.Background(),
 				tt.input,
 			)
 			if !tt.errCheck(err) {