fix: don't generate empty _default containerd mirror file #1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
previously approved these changes
Feb 11, 2025
supershal
previously approved these changes
Feb 11, 2025
dlipovetsky
previously approved these changes
Feb 11, 2025
dlipovetsky
dismissed stale reviews from supershal, jimmidyson, and themself
The base branch was changed.
|
This PR/issue depends on:
|
supershal
force-pushed
the
dkoshkin/fix-dont-generate-empty_default-containerd-file
branch
from
aa44a8b to
2769585
Compare
supershal
approved these changes
Feb 11, 2025
dlipovetsky
approved these changes
Feb 11, 2025
supershal
force-pushed
the
dkoshkin/fix-dont-generate-empty_default-containerd-file
branch
from
2769585 to
d07e56d
Compare
dlipovetsky
deleted the
dkoshkin/fix-dont-generate-empty_default-containerd-file
branch
Merged
jimmidyson
added a commit
that referenced
this pull request
Feb 12, 2025
🤖 I have created a release *beep* *boop* --- ## 0.27.0 (2025-02-12) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Update COSI controller Addon by @dlipovetsky in #1043 * feat: Build with Go 1.24.0 by @jimmidyson in #1047 ### Fixes 🔧 * fix: Specify PriorityClass for Node Feature Discovery components by @dlipovetsky in #1041 * fix: Correctly configure non-mirror registry certificates by @jimmidyson in #1039 * fix: Configure priorityClassName for Cilium Hubble by @dlipovetsky in #1045 * fix: don't generate empty _default containerd mirror file by @dkoshkin in #1042 * fix: set priority class name for metallb by @supershal in #1046 * fix: Correctly configure dynamic credential provider by @jimmidyson in #1040 **Full Changelog**: v0.26.0...v0.27.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Now that we're fixing how the
_defaultfile is being generated just for mirrors, we should skip creating the file if only registries are provided.Depends on #1039.
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: