-
Notifications
You must be signed in to change notification settings - Fork 7
fix: Correctly configure dynamic credential provider #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dlipovetsky
merged 3 commits into
main
from
jimmi/fix-dynamic-credential-provider-config
Feb 12, 2025
Merged
fix: Correctly configure dynamic credential provider #1040
dlipovetsky
merged 3 commits into
main
from
jimmi/fix-dynamic-credential-provider-config
Feb 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlipovetsky
previously approved these changes
Feb 10, 2025
187304d
to
64f9a83
Compare
UPDATE: No longer depends on #1039. |
Rebased with latest changes from the base branch and seeing correct files
|
Mirror config looks good too:
|
dkoshkin
previously approved these changes
Feb 11, 2025
64f9a83
to
3cb4ac1
Compare
The base branch was changed.
This PR/issue depends on:
|
Use for existing CCs.
It is only allowed for a single configuration per provider binary so match up the image hosts per binary in the config.
Use for existing CCs.
4f7cb66
to
5972683
Compare
dlipovetsky
approved these changes
Feb 11, 2025
supershal
approved these changes
Feb 11, 2025
Merged
jimmidyson
added a commit
that referenced
this pull request
Feb 12, 2025
🤖 I have created a release *beep* *boop* --- ## 0.27.0 (2025-02-12) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Update COSI controller Addon by @dlipovetsky in #1043 * feat: Build with Go 1.24.0 by @jimmidyson in #1047 ### Fixes 🔧 * fix: Specify PriorityClass for Node Feature Discovery components by @dlipovetsky in #1041 * fix: Correctly configure non-mirror registry certificates by @jimmidyson in #1039 * fix: Configure priorityClassName for Cilium Hubble by @dlipovetsky in #1045 * fix: don't generate empty _default containerd mirror file by @dkoshkin in #1042 * fix: set priority class name for metallb by @supershal in #1046 * fix: Correctly configure dynamic credential provider by @jimmidyson in #1040 **Full Changelog**: v0.26.0...v0.27.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only allowed a single configuration per provider binary so match up
the image hosts per binary in the config.
Depends on #1039.