-
Notifications
You must be signed in to change notification settings - Fork 7
feat: implementation for user defined configmap for cilium addon in cluster creation #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cacfc9a
to
a6a17bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and simple of a change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. we should add unit test for this or some helpers for unit tests for addons.
Can we create a followup PR/jira to add unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🤖 I have created a release *beep* *boop* --- ## 0.26.0 (2025-02-05) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: adds new field for helm values input for cilium CNI by @manoj-nutanix in #1011 * feat: implementation for user defined configmap for cilium addon in cluster creation by @manoj-nutanix in #1033 * feat: update CAPI to v1.9.3 by @dkoshkin in #1010 * feat: adds cluster's ownerref on cilium helm values source object by @manoj-nutanix in #1034 ### Fixes 🔧 * fix: correctly copy Helm charts in init container by @dkoshkin in #1018 * fix: Use mindthegap v1.17.0 for the helm-repository container by @dlipovetsky in #1024 * fix: use republished COSI controller image by @dkoshkin in #1022 ### Other Changes * test: wait for COSI controller to be ready by @dkoshkin in #1014 * refactor: Remove api module dependency from common module by @jimmidyson in #1019 **Full Changelog**: v0.25.0...v0.26.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dimitri Koshkin <[email protected]>
What problem does this PR solve?:
implementation for user defined cilium configmap in cluster creation, current PR's implementation covers only configmap kind and assumes that
clusterctl.cluster.x-k8s.io/move
label is added on configmap by user.pending PRs:
Which issue(s) this PR fixes:
Fixes #
NCN-105148
How Has This Been Tested?:
Special notes for your reviewer: