fix: Use mindthegap v1.17.0 for the helm-repository container #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version was v1.17.0, until commit a3adcb7 changed the image, and the tag, used by the helm-repository container.
dlipovetsky
requested review from
jimmidyson,
dkoshkin and
faiq
and removed request for
jimmidyson
faiq
approved these changes
Jan 24, 2025
dkoshkin
approved these changes
Jan 24, 2025
|
Is the JIRA link correct in the description I'm seeing |
Fixed 😬 |
dlipovetsky
added a commit
that referenced
this pull request
Jan 28, 2025
**What problem does this PR solve?**: The helm-repository container is defaulting to the wrong mindthegap version, one that is missing an [important fix](mesosphere/mindthegap#805). **Which issue(s) this PR fixes**: Fixes https://jira.nutanix.com/browse/NCN-104087 **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
faiq
pushed a commit
that referenced
this pull request
Jan 28, 2025
…#1027) **What problem does this PR solve?**: The helm-repository container is defaulting to the wrong mindthegap version, one that is missing an [important fix](mesosphere/mindthegap#805). Backport of #1024 **Which issue(s) this PR fixes**: Fixes https://jira.nutanix.com/browse/NCN-104087 **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. --> **What problem does this PR solve?**: **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
faiq
pushed a commit
that referenced
this pull request
Jan 28, 2025
🤖 I have created a release *beep* *boop* --- ## 0.23.2 (2025-01-28) <!-- Release notes generated using configuration in .github/release.yaml at release/v0.23.x --> ## What's Changed ### Fixes 🔧 * fix: Use mindthegap v1.17.0 for the helm-repository container (#1024) by @dlipovetsky in #1027 * fix: update CoreDNS mapping file by @dlipovetsky in #1029 **Full Changelog**: v0.23.1...v0.23.2 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
dkoshkin
added a commit
that referenced
this pull request
Feb 5, 2025
🤖 I have created a release *beep* *boop* --- ## 0.26.0 (2025-02-05) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: adds new field for helm values input for cilium CNI by @manoj-nutanix in #1011 * feat: implementation for user defined configmap for cilium addon in cluster creation by @manoj-nutanix in #1033 * feat: update CAPI to v1.9.3 by @dkoshkin in #1010 * feat: adds cluster's ownerref on cilium helm values source object by @manoj-nutanix in #1034 ### Fixes 🔧 * fix: correctly copy Helm charts in init container by @dkoshkin in #1018 * fix: Use mindthegap v1.17.0 for the helm-repository container by @dlipovetsky in #1024 * fix: use republished COSI controller image by @dkoshkin in #1022 ### Other Changes * test: wait for COSI controller to be ready by @dkoshkin in #1014 * refactor: Remove api module dependency from common module by @jimmidyson in #1019 **Full Changelog**: v0.25.0...v0.26.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dimitri Koshkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
The helm-repository container is defaulting to the wrong mindthegap version, one that is missing an important fix.
Which issue(s) this PR fixes:
Fixes https://jira.nutanix.com/browse/NCN-104087
How Has This Been Tested?:
Special notes for your reviewer: