-
-
Notifications
You must be signed in to change notification settings - Fork 119
Testing - Surge deploy #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is 2 scripts : build.sh to generate the build and deploy.sh to deploy it in surge but after the build command inside docker container next commad is not recognizing the |
50aa3ce
to
928dc38
Compare
minor change- put build script in entry point only
928dc38
to
16cbcff
Compare
When I build the newsite branch then I found that it is building following files
That should be html file instead. @joelachance Please let me know if you already know about it. |
@Shekharrajak, I don't know about the index.xml, but I'll take a look at it tomorrow. |
@Shekharrajak, check this out: https://stackoverflow.com/questions/42470517/hugo-not-generating-index-and-404-html-files According that post, it seems we may need to build the submodules. I'm thinking we may want to try |
@@ -1,3 +1,6 @@ | |||
#!/bin/sh | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we delete this file since its not being used, or do we still plan to move the build steps here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! I did see your comment in deploy.sh after I made this comment. Maybe we just delete or add a #deprecated / not being used
comment in build.sh?
Should be working now! Looks good to merge. |
Thanks @joelachance |
I am merging it if no one has any comments on this PR by tomorrow. |
LGTM, merging. Thanks @Shekharrajak! |
Should get deployed at http://pr-58-numpy.org-newsite.surge.sh/