Skip to content

Testing - Surge deploy #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 20, 2019
Merged

Testing - Surge deploy #58

merged 17 commits into from
Oct 20, 2019

Conversation

Shekharrajak
Copy link
Member

@Shekharrajak Shekharrajak commented Oct 19, 2019

@Shekharrajak
Copy link
Member Author

There is 2 scripts : build.sh to generate the build and deploy.sh to deploy it in surge but after the build command inside docker container next commad is not recognizing the ./public folder.

@Shekharrajak
Copy link
Member Author

When I build the newsite branch then I found that it is building following files

css         images      index.xml   js          sitemap.xml

That should be html file instead. @joelachance Please let me know if you already know about it.

@joelachance
Copy link
Collaborator

@Shekharrajak, I don't know about the index.xml, but I'll take a look at it tomorrow.

@joelachance
Copy link
Collaborator

@Shekharrajak, check this out:

https://stackoverflow.com/questions/42470517/hugo-not-generating-index-and-404-html-files

According that post, it seems we may need to build the submodules. I'm thinking we may want to try git submodule update --init (the command in the README) in line 2 of build.sh.

@@ -1,3 +1,6 @@
#!/bin/sh

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete this file since its not being used, or do we still plan to move the build steps here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make a note. Actually previously in this PR: #46 , I used to call the build.sh and deploy.sh separately. But now we were facing issue so I make it in one script file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! I did see your comment in deploy.sh after I made this comment. Maybe we just delete or add a #deprecated / not being used comment in build.sh?

@joelachance
Copy link
Collaborator

Should be working now! Looks good to merge.

@Shekharrajak
Copy link
Member Author

Thanks @joelachance

@Shekharrajak
Copy link
Member Author

I am merging it if no one has any comments on this PR by tomorrow.

@rgommers rgommers merged commit 1825cfb into newsite Oct 20, 2019
@rgommers rgommers deleted the gsod-newsite branch October 20, 2019 09:39
@rgommers
Copy link
Member

LGTM, merging. Thanks @Shekharrajak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants