-
-
Notifications
You must be signed in to change notification settings - Fork 119
Deployment #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@joelachance converting these to issues, and adding the correct handle for Shekhar |
For 2nd point
As far as I understand there are repositories: https://github.com/numpy/neps, https://github.com/numpy/devdocs, https://github.com/numpy/doc, https://github.com/numpy/numpy.github.com which have commits - the auto generated static HTML files using https://github.com/numpy/numpy, https://github.com/numpy/numpy.org . So now if we use Hugo for all the static pages like NEPs and pages like: about, community, conduct etc. then we don't need of separate repos: neps, numpy.github.io . We can have https://github.com/numpy/doc which will contain the generated HTML for the docstrings from the sphinx tool. So it will be deployed on https://numpy.org/doc (since https://numpy.github.io is pointing to https://numpy.org). What do you people think? Let me know if I misunderstood anything. I also want to understand more about how |
Copying the table from this comment, here are the github repos under the numpy organization, the trigger that currently causes an update, the destination dummy repo used for github pages, and the link where these github pages are published.
|
1st point :
For this we need to have some environment variables like Once I get access I will start working on surge integration . |
Note AFAICT github actions is another name for azure pipelines. I hope github actions is still a yaml-style file that is added to the repo and not some obscure gui-based, github-only thing that it will be difficult to manage. |
The circleCI integration is in these lines, as part of the CI (not an additional bot). |
Yeah thank! I checked the yml file: https://github.com/numpy/numpy/blob/master/.circleci/config.yml |
Few points I have in my mind, just want to share:
|
Where would the documents in (1-3) end up in the numpy.org site layout? Right now they are part of the /devdoc and /doc hierarchy (except for the NEPS), I understand you are proposing they go somewhere else? I am missing the big picture design |
Since they are static .rst files I believe it should be in this repository (numpy.org) Hugo version(newsite-branch). Once we have the newsite ready then we can push/commit the WDYT? Is there any specific reason to put contents in different repositories (neps, numpy.github.io, devdocs) ? |
Summary of my proposal: Hugo application - We will try to move all the static files which are not referring to docstrings (numpy codebase), can be written simply in So no this will make the maintains of the docs easy and contributors can add/modify the static pages they don't have to setup sphinx for it and Hugo makes the documentation and development easy. Docstring part - Using Sphinx we will generate the static html files for the docstring and quickstart, user guide files. Now the build can be pushed to I am trying to make the development of sphinx part easy. Please have a look at this repo: https://github.com/Shekharrajak/scipy-sphinx-theme-v2 This repo uses the grunt task runner and livereload functionality makes the development easy. Because when user changes the docs file (any .rst file) then it rebuild and serve the new content dynamically in localhost:2121 . WDYT? |
It's not, it's GitHub's CI/CD that's still in beta: https://github.com/features/actions. Is quite promising.
About, Reporting Bugs and License yes, I agree. NumPy Enhancement Proposals should stay in Sphinx.
That decision I would postpone. Could make sense, but low-prio.
This I'm also not sure about, let's leave them where they are for now.
Indeed.
`Those are all deployment repos, so they can go if we have a better deployment method. Whatever works I'd say - since those repos don't affect where and how people work on content, it's not too critical.
I'd start with only the parts that clearly belong on the website, like About and Reporting Bugs. The larger set of content is a bit painful to migrate from ReST to Markdown and it's not obvious that it will help. Also, it may interfere with the translation plan.
Yep that all looks great to me! |
Deployment tasks are done, things work well with preview and with using GH Actions for deploying via the |
We need to complete several steps:
git push
for review.@Shekharrajak, am I missing anything?
The text was updated successfully, but these errors were encountered: