-
-
Notifications
You must be signed in to change notification settings - Fork 119
point doc archive to numpy.org #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
https://numpy.org/doc is "live", the doc repo is a 77MB download with the 1.14, 1.15, 1.16 documentation. Should I add more? I guess we need 1.13 since that is the version SciPy builds against. Once numpy/numpy#13990 goes in (fixes |
What do you propose to do with the older ones? Just link to http://docs.scipy.org/doc/ as the archive for older versions? Yes, 1.13 definitely, not sure if anything else is needed, perhaps not. Also, can you please use the docs for the latest released versions on each branch, not just It would also be good to know how expensive (in terms of size) it is to add a new release. Content is often similar, but not clear to me that that helps. So if you add 1.16.4 docs and remove 1.16.5.dev0+ without rewriting git history (as an experiment, rewriting is probably best), how many MB does that add? |
We could either link to them or drop them. I think I would prefer to drop them. If there is opposition we could link to scipy.org .> .. can you please use the docs for the latest released versions on each branch, not just .dev0+? Ahh, I think I checked out maintenance/1.aa.x instead of v1.aa.b
29MB. Probably less if I do not
|
I'd suggest a link, it doesn't hurt. Older releases have some value, e.g. if a user wants to check if a function is present in that release. |
Yeah, just |
added 1.13 docs to numpy/doc (visible as https://numpy.org/doc/1.13) and unzipped the zip archive for 1.16, 1.15, 1.14 docs without
|
Maybe I am wrong, but I have a feeling that if html pages can be auto-generated, probably they should not be kept in git. |
The four repos I mentioned above all contain generated documentation that is served via github pages, which is a convenient way to serve static pages. This requires checking the rendered documentation into a repo. Another option is to host the pages on a hosting service where we would copy the static pages. @dashohoxha do you know of such hosting that would be reliable, free, stable, and would require no maintenance from us? |
Lately I have started using GitLab, and it allows you to run your own build script, which generates the pages that you want to publish. It looks something like this: For GitHub I was not sure whether this could be done, however I found this doc which explains how to do it: It seems much more complicated than GitLab, but at least it is possible. |
The right blog is this one: https://circleci.com/blog/deploying-documentation-to-github-pages-with-continuous-integration/ |
I would love to avoid committing the archived documentation into a repo, but the other choices seem less optimal. My departure point is that we do not want to maintain our own document server. The blog post you linked to states
What workflow would support generating on-the-fly different versions of the documentation from the
Each time we wish to update the archived documentation, we would have to build all the versions, which sounds brittle. Perhaps at some point, when this repo grows to be unwieldy, we will be forced to find another solution, but I think this proposal will keep us going for another decade or so. |
I think that we would have to use a build script that does all these steps, for example |
@dashohoxha Given that 5 years of documentation fits into 120MB, I think archiving versions is preferable to containerization + tooling + CI integration, especially since we are discussing a run-only-at-release process that should not get a lot of traffic. We can revisit this decision if the release manager finds the |
@mattip I do not insist, I just made a suggestion. Keeping it simple is better. |
@rgommers ping |
thanks for the ping @mattip, merged. I did note that there's no way to get back from |
That has to do with templating in the numpy/numpy repo. I will see if I can change it. |
@mattip I could not quite distill from this entire discussion the current build workflow. Does the documentation auto-update for 1.17.x releases, and those all end up at the same URL? That's what we do for skimage, e.g.: https://scikit-image.org/docs/0.15.x/ We do not try to keep the archive small for scikit-image, but at some point we'll probably need to do that by removing a bunch of history. I get the feeling that NumPy would take a while longer to run into that problem. And I thought (although I might be mistaken), that you can now Are steps planned to highlight the current version of the documentation displayed, and to provide a mechanism to navigate to newer/older versions? |
@stefanv the documentation release workflow is now (in the numpy repo, not here)
If there are clever ways to improve the clone/add/commit/push git workflow, they can be added to the Adding a version widget was PR numpy/numpy#12097 which was closed not merged. |
As per the new spec, point to numpy.org/doc for archived documents and numpy.org/neps for neps
This still leaves the numpy org with 4 html repos (3 once we fold neps into devdocs) dedicated to github pages.
master
master
master