This repository was archived by the owner on May 10, 2021. It is now read-only.
fix: fallback blocking would cause builds to crash #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindsaylevine
force-pushed
the
ll/fallback-blocking-fix
branch
from
4a959f3 to
0d27aa3
Compare
|
This looks great! Thanks for implementing, @lindsaylevine! If Cypress tests pass, this can be merged IMO 👍 |
lindsaylevine
force-pushed
the
ll/fallback-blocking-fix
branch
from
0d27aa3 to
7d82423
Compare
lindsaylevine
added a commit
that referenced
this pull request
Jan 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111
for pages with fallback: "blocking", they're generated into prerender-manifest's
dynamicRoutesas havingfallback: null, notfallback: false. therefore, our previous check failed to exclude those pages, so anyone trying to use fallback: blocking with NoN would get the next_whatever_page_it_is.js already exists failure.