This repository was archived by the owner on May 10, 2021. It is now read-only.
initial support for next/image on netlify #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindsaylevine
added
the
type: feature
lindsaylevine
commented
Jan 9, 2021
| const quality = parseInt(q); | ||
|
|
||
| const imageUrl = url.startsWith("/") | ||
| ? `${process.env.URL || "http://localhost:8888"}${url}` |
There was a problem hiding this comment.
not sure about this ||, but i think it's fine since ntl dev uses 8888 as its default port right?
There was a problem hiding this comment.
this is probably okay in the short term, but the port is configurable. quick fix is the create a .env with URL=http://localhost:5432 or whatever to override locally
|
|
||
| // Function used to mimic next/image and sharp | ||
| exports.handler = async (event) => { | ||
| const { url, w = 500, q = 75 } = event.queryStringParameters; |
There was a problem hiding this comment.
not sure about these defaults but i think it's fine since next_image should almost always provide w
There was a problem hiding this comment.
we probably want some reasonable default just in case so we don't end up trying to process 6MB images at full res or whatever, but I think you're right that it should always be set
jlengstorf
approved these changes
Jan 13, 2021
Co-authored-by: Jason Lengstorf <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70
as this comment points out, this solution for initial support is not performant because the function will re-run on every request without any caching. that said, this PR is just initial support. we have performance improvements on our roadmap, depending on internal work at netlify. this PR adds this caveat to our README.
my plan, once this PR is merged, is to close #70, open a new issue that addresses performance, and update #70 so anyone from there can follow the new issue.
s/o to @jlengstorf for doing the 90% of work ahead of this PR 🙏