Fixed Session#reset() to only send a RESET message
#456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connection error can happen while transaction is executing. Closing transaction after such error should not perform rollback because connection is dead and database has cleaned up all resources. Previously close operation tried to perform rollback and failed with same `ServiceUnavailable` exception as the unsuccessful `#run()`. Error thrown from `#close()` has to be added as a suppressed error to the one thrown from `#run()`, when used in try-with-resources block. So code attempted to add error to itself as suppressed. This resulted in an `IllegalArgumentException`. This commit fixes the problem by making `#close()` not perform a rollback after a fatal connection error.
New condition is the same as old one by reads a bit better.
Session can only have one active (not closed) transaction at a time. Exception is thrown when starting a transaction on a session that already has an open one. Situation when transaction is started multiple times on a session with an open transaction was not handled correctly. First failure overrode the reference to the last transaction kept in the session. Later attempts resulted in a different error saying that there already exists an open connection. This commit fixes the problem by making session keep current transaction reference even if new transaction failed to begin. So callers will receive consistent errors.
lutovich
force-pushed
the
1.5-session-reset-fix
branch
4 times, most recently
from
1dca59d to
6cb060b
Compare
Instead of sending RESET message and returning connection back to the pool. Queries & transactions should still be in control of the connection lifecycle even after reset. Previous behaviour was problematic because reset might race with query execution and make it try to use connection that has been returned to the pool. Also moved all RESET tests to a dedicated `SessionResetIT`. Made explicit transaction remain open after termination so that user code still needs to close it to return connection to the pool.
Commit adds couple stub-server tests to assert that commit and rollback errors are correctly propagated.
lutovich
force-pushed
the
1.5-session-reset-fix
branch
from
6cb060b to
f3ae1d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #454.