Tests for commit and rollback error propagation

Commit adds couple stub-server tests to assert that commit and
rollback errors are correctly propagated.

Author: lutovich

driver/src/test/java/org/neo4j/driver/v1/integration/TransactionIT.java

@@ -28,15 +28,19 @@
 import org.neo4j.driver.internal.cluster.RoutingSettings;
 import org.neo4j.driver.internal.util.ChannelTrackingDriverFactory;
 import org.neo4j.driver.internal.util.Clock;
+import org.neo4j.driver.v1.AuthTokens;
 import org.neo4j.driver.v1.Config;
 import org.neo4j.driver.v1.Driver;
+import org.neo4j.driver.v1.GraphDatabase;
 import org.neo4j.driver.v1.Record;
 import org.neo4j.driver.v1.Session;
 import org.neo4j.driver.v1.StatementResult;
 import org.neo4j.driver.v1.Transaction;
 import org.neo4j.driver.v1.Value;
 import org.neo4j.driver.v1.exceptions.ClientException;
 import org.neo4j.driver.v1.exceptions.ServiceUnavailableException;
+import org.neo4j.driver.v1.exceptions.TransientException;
+import org.neo4j.driver.v1.util.StubServer;
 import org.neo4j.driver.v1.util.TestNeo4jSession;
 import org.neo4j.driver.v1.util.TestUtil;
 
@@ -385,6 +389,18 @@ public void shouldThrowWhenConnectionKilledDuringTransactionMarkedForSuccess()
         testFailWhenConnectionKilledDuringTransaction( true );
     }
 
+    @Test
+    public void shouldThrowCommitError() throws Exception
+    {
+        testTxCloseErrorPropagation( "commit_error.script", true, "Unable to commit" );
+    }
+
+    @Test
+    public void shouldThrowRollbackError() throws Exception
+    {
+        testTxCloseErrorPropagation( "rollback_error.script", false, "Unable to rollback" );
+    }
+
     private void testFailWhenConnectionKilledDuringTransaction( boolean markForSuccess )
     {
         ChannelTrackingDriverFactory factory = new ChannelTrackingDriverFactory( 1, Clock.SYSTEM );
@@ -420,4 +436,45 @@ private void testFailWhenConnectionKilledDuringTransaction( boolean markForSucce
 
         assertEquals( 0, session.run( "MATCH (n:MyNode {id: 1}) RETURN count(n)" ).single().get( 0 ).asInt() );
     }
+
+    private static void testTxCloseErrorPropagation( String script, boolean commit, String expectedErrorMessage )
+            throws Exception
+    {
+        StubServer server = StubServer.start( script, 9001 );
+        try
+        {
+            Config config = Config.build().withLogging( DEV_NULL_LOGGING ).withoutEncryption().toConfig();
+            try ( Driver driver = GraphDatabase.driver( "bolt://localhost:9001", AuthTokens.none(), config );
+                  Session session = driver.session() )
+            {
+                Transaction tx = session.beginTransaction();
+                StatementResult result = tx.run( "CREATE (n {name:'Alice'}) RETURN n.name AS name" );
+                assertEquals( "Alice", result.single().get( "name" ).asString() );
+
+                if ( commit )
+                {
+                    tx.success();
+                }
+                else
+                {
+                    tx.failure();
+                }
+
+                try
+                {
+                    tx.close();
+                    fail( "Exception expected" );
+                }
+                catch ( TransientException e )
+                {
+                    assertEquals( "Neo.TransientError.General.DatabaseUnavailable", e.code() );
+                    assertEquals( expectedErrorMessage, e.getMessage() );
+                }
+            }
+        }
+        finally
+        {
+            assertEquals( 0, server.exitStatus() );
+        }
+    }
 }

driver/src/test/resources/commit_error.script

@@ -0,0 +1,18 @@
+!: AUTO INIT
+!: AUTO RESET
+
+C: RUN "BEGIN" {}
+   PULL_ALL
+S: SUCCESS {}
+   SUCCESS {}
+C: RUN "CREATE (n {name:'Alice'}) RETURN n.name AS name" {}
+   PULL_ALL
+S: SUCCESS {"fields": ["name"]}
+   RECORD ["Alice"]
+   SUCCESS {}
+C: RUN "COMMIT" {}
+   PULL_ALL
+S: FAILURE {"code": "Neo.TransientError.General.DatabaseUnavailable", "message": "Unable to commit"}
+   IGNORED
+C: ACK_FAILURE
+S: SUCCESS {}

driver/src/test/resources/rollback_error.script

@@ -0,0 +1,18 @@
+!: AUTO INIT
+!: AUTO RESET
+
+C: RUN "BEGIN" {}
+   PULL_ALL
+S: SUCCESS {}
+   SUCCESS {}
+C: RUN "CREATE (n {name:'Alice'}) RETURN n.name AS name" {}
+   PULL_ALL
+S: SUCCESS {"fields": ["name"]}
+   RECORD ["Alice"]
+   SUCCESS {}
+C: RUN "ROLLBACK" {}
+   PULL_ALL
+S: FAILURE {"code": "Neo.TransientError.General.DatabaseUnavailable", "message": "Unable to rollback"}
+   IGNORED
+C: ACK_FAILURE
+S: SUCCESS {}